'Re: Review Request 123489: Remove unnecessary k3listview includes'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: Review Request 123489: Remove unnecessary k3listview includes
From:       Pali_Rohár <pali.rohar () gmail ! com>
Date:       2015-05-01 9:21:28
Message-ID: 20150501092128.32057.76883 () mimi ! kde ! org
[Download RAW message or body]

--===============2054600434205545017==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123489/#review79757
-----------------------------------------------------------

Patch is OK. Now try to setup your own personal cloned git repository and commit this \
patch into it (do not remember "REVIEW: 123489" keywoard in commit message).

- Pali Rohár

On apr. 26, 2015, 7:54 popoludní, R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123489/
> -----------------------------------------------------------
> 
> (Updated apr. 26, 2015, 7:54 popoludní)
> 
> 
> Review request for Kopete and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> -------
> 
> The following k3listview includes do not affect complilation and/or run of the \
> kopete application. 
> 
> Diffs
> -----
> 
> kopete/contactlist/kopetestatusgroupviewitem.h \
> e691e66c03cdd631c739875914f80403c5edebc7  plugins/alias/aliaspreferences.cpp \
> 19e54202e8978e27e354cc2014ffde1d39714dc1  plugins/alias/editaliasdialog.cpp \
> fed313c237de3fc18c8e4de298c74a641011675f  \
> plugins/highlight/highlightpreferences.cpp 891dc22f90c0253e36cbdae6b36f4b62a33f5ff8 \
>  protocols/gadu/gadupubdir.cpp 32d5a3dc425ac4d64aa124c62fa172910b3f2a98 
> protocols/groupwise/ui/gwcontactproperties.cpp \
> c383585d1744053ffd09ee04a0629661839526ea  
> Diff: https://git.reviewboard.kde.org/r/123489/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ran kopete shell application. No exceptions or warnings thrown.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
> 

--===============2054600434205545017==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123489/">https://git.reviewboard.kde.org/r/123489/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Patch \
is OK. Now try to setup your own personal cloned git repository and commit this patch \
into it (do not remember "REVIEW: 123489" keywoard in commit message).</p></pre>  <br \
/>

<p>- Pali Rohár</p>

<br />
<p>On apríl 26th, 2015, 7:54 popoludní CEST, R.Harish  Navnit wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kopete and Pali Rohár.</div>
<div>By R.Harish  Navnit.</div>

<p style="color: grey;"><i>Updated apr. 26, 2015, 7:54 popoludní</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kopete
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The following k3listview includes do not affect \
complilation and/or run of the kopete application.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiled and ran kopete shell application. No \
exceptions or warnings thrown.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kopete/contactlist/kopetestatusgroupviewitem.h <span style="color: \
grey">(e691e66c03cdd631c739875914f80403c5edebc7)</span></li>

 <li>plugins/alias/aliaspreferences.cpp <span style="color: \
grey">(19e54202e8978e27e354cc2014ffde1d39714dc1)</span></li>

 <li>plugins/alias/editaliasdialog.cpp <span style="color: \
grey">(fed313c237de3fc18c8e4de298c74a641011675f)</span></li>

 <li>plugins/highlight/highlightpreferences.cpp <span style="color: \
grey">(891dc22f90c0253e36cbdae6b36f4b62a33f5ff8)</span></li>

 <li>protocols/gadu/gadupubdir.cpp <span style="color: \
grey">(32d5a3dc425ac4d64aa124c62fa172910b3f2a98)</span></li>

 <li>protocols/groupwise/ui/gwcontactproperties.cpp <span style="color: \
grey">(c383585d1744053ffd09ee04a0629661839526ea)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123489/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2054600434205545017==--

[Attachment #3 (text/plain)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

[prev in list] [next in list] [prev in thread] [next in thread] 