'Re: Review Request: Fix a bug in kopete nowlistening preferences kcm'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: Review Request: Fix a bug in kopete nowlistening preferences kcm
From:       cyberbeat () gmx ! de
Date:       2012-11-11 10:01:01
Message-ID: 20121111100101.11253.52422 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6977/#review10991
-----------------------------------------------------------

if noone speaks against, then I'll commit this fix to trunk tomorrow

- Cyberbeat

On June 6, 2012, 2:35 p.m., Cyberbeat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6977/
> -----------------------------------------------------------
> 
> (Updated June 6, 2012, 2:35 p.m.)
> 
> 
> Review request for Kopete.
> 
> 
> Description
> -------
> 
> To reproduce the bug in nowlistening preferences kcm:
> 
> - open the preferences for nowlistening plugin
> - in the third tab check the checkbox and choose a mediaplayer
> - close the dialog
> - open preferences again (the checkbox is now already checked)
> - choose another mediaplayer
> - close the dialog
> ==> the mediaplayer-selection is not applied
> test that by opening the preferences again and look
> 
> This patch replaces the k3listbox by a klistwidget, which solves the problem, and \
> seems a good idea anyway because k3listbox will be removed someday. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningpreferences.cpp \
>                 1298638 
> /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningprefs.ui 1298638 
> 
> Diff: http://svn.reviewboard.kde.org/r/6977/diff/
> 
> 
> Testing
> -------
> 
> works for me
> 
> 
> Thanks,
> 
> Cyberbeat
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6977/">http://svn.reviewboard.kde.org/r/6977/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">if noone speaks against, \
then I&#39;ll commit this fix to trunk tomorrow</pre>  <br />

<p>- Cyberbeat</p>

<br />
<p>On June 6th, 2012, 2:35 p.m., Cyberbeat wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kopete.</div>
<div>By Cyberbeat.</div>

<p style="color: grey;"><i>Updated June 6, 2012, 2:35 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">To reproduce the bug in nowlistening preferences kcm:

- open the preferences for nowlistening plugin
- in the third tab check the checkbox and choose a mediaplayer
- close the dialog
- open preferences again (the checkbox is now already checked)
- choose another mediaplayer
- close the dialog
==&gt; the mediaplayer-selection is not applied
test that by opening the preferences again and look

This patch replaces the k3listbox by a klistwidget, which solves the problem, and \
seems a good idea anyway because k3listbox will be removed someday.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works for me</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningpreferences.cpp \
<span style="color: grey">(1298638)</span></li>

 <li>/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningprefs.ui <span \
style="color: grey">(1298638)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6977/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

[prev in list] [next in list] [prev in thread] [next in thread] 