From kopete-devel Wed Oct 24 18:13:55 2012 From: "Lamarque V. Souza" Date: Wed, 24 Oct 2012 18:13:55 +0000 To: kopete-devel Subject: Re: Kopete crashes in Kopete::MetaContact::isOnline() Message-Id: <201210241613.55705.lamarque () kde ! org> X-MARC-Message: https://marc.info/?l=kopete-devel&m=135110245824066 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4023480535809953002==" --===============4023480535809953002== Content-Type: multipart/alternative; boundary="Boundary-01=_j/CiQliZVaukkwD" Content-Transfer-Encoding: 7bit --Boundary-01=_j/CiQliZVaukkwD Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Em Wednesday 24 October 2012, Pali Roh=E1r escreveu: > On Monday 22 October 2012 14:31:25 Pali Roh=E1r wrote: > > On Sunday 07 October 2012 14:17:29 Lamarque V. Souza wrote: > > > Em Wednesday 03 October 2012, Christoph Feck escreveu: > > > > Hi Kopete developers, > > > =09 > > > Hi, > > > =09 > > > > since KDE 4.8.80 (KDE 4.9 alpha), we get multiple bug > > > > reports > > > > about Kopete crashing around > > > > Kopete::MetaContact::isOnline(), see bug 301989 and newers > > > > (links below) even when simply starting it. > > > >=20 > > > > It looks like those are caused by the network status > > > > updates > > > > (commits r1283434, r1285546 ... r1289685) or the new > > > > offline > > > > group (commit r1282381). > > > >=20 > > > > Could you have a look at the issue? > > > =09 > > > Well, I am trying to figure out why it crashes but I have >=20 > no >=20 > > > clue yet. I am able to reproduce the crash and have a > > > valgrind > > > log (attached to https://bugs.kde.org/show_bug.cgi?id=3D229996) > > > but I still do not see why it crashes. The crash seems older > > > than all those commits above, maybe the commits make the > > > problem more often, but I do not think they are the cause. > >=20 > > Hello, I think that above commits did not intorduced this > > crash. > >=20 > > Kopete is crashing in function Kopete::MetaContact::isOnline. I > > think it can happen only if Kopete::MetaContact object or > > Kopete::Contact is deleted (pointer to *this is invalid). And > > this can be in situation when you delete some metacontact > > (move all subcontacts to other metacontact). Maybe quick & > > dirty fix can be to use qt shared pointer to fix problem of > > invalid pointer. >=20 > I created patch with using QPointer (instead C++ pointer), so Qt > can handle deleting Kopete::MetaContact QObject and mark it as > NULL. This fixed crashing Kopete on my computer and I'm not able > to reproduce this bug again. >=20 > Patch is here: https://bugs.kde.org/show_bug.cgi?id=3D229996#c10 >=20 > Please test it and let me know if it really fixed this problem! No crash here so far, so ship it :-) =2D-=20 Lamarque V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br --Boundary-01=_j/CiQliZVaukkwD Content-Type: text/html; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable

Em Wednesda= y 24 October 2012, Pali Roh=E1r escreveu:

> On Mon= day 22 October 2012 14:31:25 Pali Roh=E1r wrote:

> > O= n Sunday 07 October 2012 14:17:29 Lamarque V. Souza wrote:

> > &= gt; Em Wednesday 03 October 2012, Christoph Feck escreveu:

> > &= gt; > Hi Kopete developers,

> > &= gt;

> > &= gt; Hi,

> > &= gt;

> > &= gt; > since KDE 4.8.80 (KDE 4.9 alpha), we get multiple bug

> > &= gt; > reports

> > &= gt; > about Kopete crashing around

> > &= gt; > Kopete::MetaContact::isOnline(), see bug 301989 and newers

> > &= gt; > (links below) even when simply starting it.

> > &= gt; >

> > &= gt; > It looks like those are caused by the network status

> > &= gt; > updates

> > &= gt; > (commits r1283434, r1285546 ... r1289685) or the new

> > &= gt; > offline

> > &= gt; > group (commit r1282381).

> > &= gt; >

> > &= gt; > Could you have a look at the issue?

> > &= gt;

> > &= gt; Well, I am trying to figure out why it crashes but I have

> no

> > &= gt; clue yet. I am able to reproduce the crash and have a

> > &= gt; valgrind

> > &= gt; log (attached to https://bugs.kde.org/show_bug.cgi?id=3D229996)

> > &= gt; but I still do not see why it crashes. The crash seems older

> > &= gt; than all those commits above, maybe the commits make the

> > &= gt; problem more often, but I do not think they are the cause.

> > <= /p>

> > H= ello, I think that above commits did not intorduced this

> > c= rash.

> > <= /p>

> > K= opete is crashing in function Kopete::MetaContact::isOnline. I

> > t= hink it can happen only if Kopete::MetaContact object or

> > K= opete::Contact is deleted (pointer to *this is invalid). And

> > t= his can be in situation when you delete some metacontact

> > (= move all subcontacts to other metacontact). Maybe quick &

> > d= irty fix can be to use qt shared pointer to fix problem of

> > i= nvalid pointer.

> I crea= ted patch with using QPointer (instead C++ pointer), so Qt

> can ha= ndle deleting Kopete::MetaContact QObject and mark it as

> NULL. = This fixed crashing Kopete on my computer and I'm not able

> to rep= roduce this bug again.

> Patch = is here: https://bugs.kde.org/show_bug.cgi?id=3D229996#c10

> Please= test it and let me know if it really fixed this problem!

&nb= sp;

No crash h= ere so far, so ship it :-)

&nb= sp;

Lamarque V.= Souza

KDE's Netwo= rk Management maintainer

http://plan= etkde.org/pt-br

--Boundary-01=_j/CiQliZVaukkwD-- --===============4023480535809953002== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel --===============4023480535809953002==--