'Re: Review Request: Add support for mpris2 in nowlistening-plugin'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: Review Request: Add support for mpris2 in nowlistening-plugin
From:       cyberbeat () gmx ! de
Date:       2012-05-31 16:22:54
Message-ID: 20120531162254.29976.1800 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6960/
-----------------------------------------------------------

(Updated May 31, 2012, 4:22 p.m.)

Review request for Kopete.

Changes
-------

This revision includes a fix for the kcm_module mediaplayer-selection.

Description
-------

Add support for mpris2 in nowlistening-plugin

Diffs (updated)
-----

  /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/CMakeLists.txt 1297322 =

  /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.h PRE-CREATION =

  /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp PRE-CREATI=
ON =

  /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningplugin.cpp =
1297322 =

  /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningpreferences=
.cpp 1297322 =

  /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningprefs.ui 12=
97322 =

Diff: http://svn.reviewboard.kde.org/r/6960/diff/

Testing
-------

works for me (banshee)

Thanks,

Cyberbeat

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6960/">http://svn.reviewboard.kde.org/r/6960/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kopete.</div>
<div>By Cyberbeat.</div>

<p style="color: grey;"><i>Updated May 31, 2012, 4:22 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This revision includes a fix for the kcm_module \
mediaplayer-selection.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add support for mpris2 in nowlistening-plugin</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works for me (banshee)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/CMakeLists.txt <span \
style="color: grey">(1297322)</span></li>

 <li>/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningplugin.cpp <span \
style="color: grey">(1297322)</span></li>

 <li>/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningpreferences.cpp \
<span style="color: grey">(1297322)</span></li>

 <li>/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningprefs.ui <span \
style="color: grey">(1297322)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6960/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

[prev in list] [next in list] [prev in thread] [next in thread] 