'Re: Review Request: Add support for mpris2 in nowlistening-plugin'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: Review Request: Add support for mpris2 in nowlistening-plugin
From:       "Lamarque Souza" <lamarque () kde ! org>
Date:       2012-05-31 0:01:44
Message-ID: 20120531000144.12227.47648 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6960/#review10807
-----------------------------------------------------------

/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp
<http://svn.reviewboard.kde.org/r/6960/#comment13400>

    This implementation is basically a copy of the mpris plugin replacing t=
he dbus service and interface names. In the original mpris implementation t=
his line search for the string "org.mpris." and not "org.mpris.MediaPlayer"=
. Now I am in doubt if this line should also be "org.mpris." or the other l=
ine should be "org.mpris.MediaPlayer". I am not an expert in mpris so I do =
not know each one should be used here.

/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp
<http://svn.reviewboard.kde.org/r/6960/#comment13402>

    just a petty peeve: you should be consistent in the code styling. Here =
there are one space missing after '(' and one before ')'. Actually there ar=
e several inconsistences in the code style for the 'if (...)' clause in thi=
s patch.

/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp
<http://svn.reviewboard.kde.org/r/6960/#comment13401>

    please remove extra line.

/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp
<http://svn.reviewboard.kde.org/r/6960/#comment13398>

    remove extra space.

/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp
<http://svn.reviewboard.kde.org/r/6960/#comment13399>

    remove extra spaces.

- Lamarque Souza

On May 30, 2012, 11:23 p.m., Cyberbeat wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6960/
> -----------------------------------------------------------
> =

> (Updated May 30, 2012, 11:23 p.m.)
> =

> =

> Review request for Kopete.
> =

> =

> Description
> -------
> =

> Add support for mpris2 in nowlistening-plugin
> =

> =

> Diffs
> -----
> =

>   /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/CMakeLists.txt 129732=
2 =

>   /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.h PRE-CREATI=
ON =

>   /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp PRE-CREA=
TION =

>   /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningplugin.cp=
p 1297322 =

>   /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningpreferenc=
es.cpp 1297322 =

> =

> Diff: http://svn.reviewboard.kde.org/r/6960/diff/
> =

> =

> Testing
> -------
> =

> works for me (banshee)
> =

> =

> Thanks,
> =

> Cyberbeat
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6960/">http://svn.reviewboard.kde.org/r/6960/</a>
  </td>
    </tr>
   </table>
   <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/6960/diff/1/?file=48034#file48034line61" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void NLmpris2::update()</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">61</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb">	</span><span class="tb">	</span><span class="tb">	</span><span \
class="tb">	</span><span class="n">services</span> <span class="o">=</span> <span \
class="n">reply</span><span class="p">.</span><span class="n">value</span><span \
class="p">().</span><span class="n">filter</span><span class="p">(</span> <span \
class="s">&quot;org.mpris.MediaPlayer2&quot;</span> <span \
class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This \
implementation is basically a copy of the mpris plugin replacing the dbus service and \
interface names. In the original mpris implementation this line search for the string \
&quot;org.mpris.&quot; and not &quot;org.mpris.MediaPlayer&quot;. Now I am in doubt \
if this line should also be &quot;org.mpris.&quot; or the other line should be \
&quot;org.mpris.MediaPlayer&quot;. I am not an expert in mpris so I do not know each \
one should be used here.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/6960/diff/1/?file=48034#file48034line71" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void NLmpris2::update()</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">71</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb">	</span><span class="tb">	</span><span class="k">if</span> <span \
class="p">(</span><span class="n">m_client</span> <span class="o">!=</span> <span \
class="mi">0</span><span class="p">){</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">just a \
petty peeve: you should be consistent in the code styling. Here there are one space \
missing after &#39;(&#39; and one before &#39;)&#39;. Actually there are several \
inconsistences in the code style for the &#39;if (...)&#39; clause in this \
patch.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/6960/diff/1/?file=48034#file48034line92" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void NLmpris2::update()</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">92</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  \
</tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">please \
remove extra line.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/6960/diff/1/?file=48034#file48034line107" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void NLmpris2::update()</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">107</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb">	</span><span class="p">}</span><span class="ew"><span \
class="tb">	</span></span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">remove \
extra space.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/6960/diff/1/?file=48034#file48034line113" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void NLmpris2::update()</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">113</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="ew"><span class="tb">	</span></span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">remove \
extra spaces.</pre> </div>
<br />

<p>- Lamarque</p>

<br />
<p>On May 30th, 2012, 11:23 p.m., Cyberbeat wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kopete.</div>
<div>By Cyberbeat.</div>

<p style="color: grey;"><i>Updated May 30, 2012, 11:23 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add support for mpris2 in nowlistening-plugin</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works for me (banshee)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/CMakeLists.txt <span \
style="color: grey">(1297322)</span></li>

 <li>/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningplugin.cpp <span \
style="color: grey">(1297322)</span></li>

 <li>/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningpreferences.cpp \
<span style="color: grey">(1297322)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6960/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

[prev in list] [next in list] [prev in thread] [next in thread] 