[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Re: Review Request: Do not ignore action moving contact to group from Gui if some accounts are offli
From: "Lamarque Souza" <lamarque () kde ! org>
Date: 2012-05-10 14:56:19
Message-ID: 20120510145619.8855.11056 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6773/#review10793
-----------------------------------------------------------
/trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp
<http://svn.reviewboard.kde.org/r/6773/#comment13359>
As far as I know if the account is offline the move process is not going to work. \
I do not see why ask the user to do something that will not work. If you want to \
inform the user about that you should just show a warning message instead.
- Lamarque Souza
On Feb. 25, 2012, 6:40 p.m., Pali Rohár wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6773/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2012, 6:40 p.m.)
>
>
> Review request for Kopete.
>
>
> Description
> -------
>
> Instead ignoring action move contact to group (and do not show any \
> warning/message), this patch ask user warning message if he really want to move \
> contact to group. This can be usefull if some accounts are offline and user want to \
> move metacontact (with contact belong to offline account) into other group.
>
> This addresses bug 202862.
> https://bugs.kde.org/show_bug.cgi?id=202862
>
>
> Diffs
> -----
>
> /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp 1282223
>
> Diff: http://svn.reviewboard.kde.org/r/6773/diff/
>
>
> Testing
> -------
>
> Tested and working fine.
>
>
> Thanks,
>
> Pali Rohár
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6773/">http://svn.reviewboard.kde.org/r/6773/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/6773/diff/2/?file=47673#file47673line441" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KopeteContactListView::moveToGroup()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">441</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span><span class="hl"><span \
class="tb"> </span></span><span class="k"><span class="hl">return</span></span><span \
class="p"><span class="hl">;</span></span> <span class="c1">// Some <span \
class="hl">contact is</span> offline we can't move it</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">441</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="p"><span class="hl">{</span></span> <span class="c1">// Some <span \
class="hl">accounts are</span> offline we can't move it</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As far as I \
know if the account is offline the move process is not going to work. I do not see \
why ask the user to do something that will not work. If you want to inform the user \
about that you should just show a warning message instead.</pre> </div>
<br />
<p>- Lamarque</p>
<br />
<p>On February 25th, 2012, 6:40 p.m., Pali Rohár wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kopete.</div>
<div>By Pali Rohár.</div>
<p style="color: grey;"><i>Updated Feb. 25, 2012, 6:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Instead ignoring action move contact to group (and do not show any \
warning/message), this patch ask user warning message if he really want to move \
contact to group. This can be usefull if some accounts are offline and user want to \
move metacontact (with contact belong to offline account) into other group.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested and working fine.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=202862">202862</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopetecontactlistview.cpp <span \
style="color: grey">(1282223)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6773/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic