--===============8078090672046053699== Content-Type: multipart/alternative; boundary="===============5049589461699805134==" --===============5049589461699805134== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Feb. 25, 2012, 8:12 p.m., Pali Roh=C3=A1r wrote: > > Was this patch commited to trunk or not? I had not, I have commited it. Unfortunately, svn has not closed this reque= st so the author of the request please close it. - Lamarque ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5282/#review10699 ----------------------------------------------------------- On Sept. 9, 2010, 10:50 a.m., Igor Poboiko wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5282/ > ----------------------------------------------------------- > = > (Updated Sept. 9, 2010, 10:50 a.m.) > = > = > Review request for Kopete. > = > = > Description > ------- > = > This patch adds notifications about status message in kopete chatwindow a= bout contact's changed status message. It also fixes bug 160510 when status= doesn't change, but kopete shows an notification about it. > = > = > This addresses bugs 160510 and 193402. > https://bugs.kde.org/show_bug.cgi?id=3D160510 > https://bugs.kde.org/show_bug.cgi?id=3D193402 > = > = > Diffs > ----- > = > /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatview.h 1172680 = > /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatview.cpp 1172680 = > /trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.h 1172680 = > /trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.cpp 1172680 = > /trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.h 1172680 = > /trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.cpp 1172680 = > /trunk/KDE/kdenetwork/kopete/protocols/oscar/aim/aimuserinfo.cpp 117268= 0 = > /trunk/KDE/kdenetwork/kopete/protocols/oscar/icq/icqcontact.cpp 1172680 = > /trunk/KDE/kdenetwork/kopete/protocols/oscar/icqcontactbase.cpp 1172680 = > /trunk/KDE/kdenetwork/kopete/protocols/oscar/oscarcontact.h 1172680 = > /trunk/KDE/kdenetwork/kopete/protocols/oscar/oscarcontact.cpp 1172680 = > = > Diff: http://svn.reviewboard.kde.org/r/5282/diff/ > = > = > Testing > ------- > = > Kopete from trunk compiles fine with it. It shows notifications for every= user in chat (except the ones who haven't status messages). There is one p= roblem: if user changes Xtraz status, it shows two notifications (because o= scar protocol sends a message with status message, then kopete asks user ab= out his status message and then sets it one more time - see attached screen= shot). I don't know what to do with it. Suggestions are welcome. > = > = > Screenshots > ----------- > = > Chat window (Hacker theme) > http://svn.reviewboard.kde.org/r/5282/s/500/ > = > = > Thanks, > = > Igor Poboiko > = > --===============5049589461699805134== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5282/

On February 25th, 2012, 8:12 p.m., Pali Roh= =C3=A1r wrote:
Was this =
patch commited to trunk or not?

I had not, =
I have commited it. Unfortunately, svn has not closed this request so the a=
uthor of the request please close it.

- Lamarque

On September 9th, 2010, 10:50 a.m., Igor Poboiko wrote:

Review request for Kopete.

By Igor Poboiko.

Updated Sept. 9, 2010, 10:50 a.m.

Descripti= on

This patch adds notifications about status message in kopete=
 chatwindow about contact's changed status message. It also fixes bug 1=
60510 when status doesn't change, but kopete shows an notification abou=
t it.

Testing <= /h1>

Kopete from trunk compiles fine with it. It shows notificati=
ons for every user in chat (except the ones who haven't status messages=
). There is one problem: if user changes Xtraz status, it shows two notific=
ations (because oscar protocol sends a message with status message, then ko=
pete asks user about his status message and then sets it one more time - se=
e attached screenshot). I don't know what to do with it. Suggestions ar=
e welcome.

Bugs: 160510, = 193402

Diffs=

/trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatview.h (1172680)
/trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatview.cpp (1172680)
/trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.h (1172680)
/trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.cpp (1172680)
/trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.h (1172680)
/trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.cpp (1172680)
/trunk/KDE/kdenetwork/kopete/protocols/oscar/aim/aimuserinfo.cpp (1172680)
/trunk/KDE/kdenetwork/kopete/protocols/oscar/icq/icqcontact.cpp (1172680)
/trunk/KDE/kdenetwork/kopete/protocols/oscar/icqcontactbase.cpp (1172680)
/trunk/KDE/kdenetwork/kopete/protocols/oscar/oscarcontact.h (1172680)
/trunk/KDE/kdenetwork/kopete/protocols/oscar/oscarcontact.cpp (1172680)

Screensho= ts

3D"Chat

--===============5049589461699805134==-- --===============8078090672046053699== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel --===============8078090672046053699==--