From kopete-devel Sat Feb 25 20:00:49 2012 From: "Lamarque V. Souza" Date: Sat, 25 Feb 2012 20:00:49 +0000 To: kopete-devel Subject: Re: Review Request: Kopete: Automatically logout and login with suspend/resume Message-Id: <201202251800.49898.lamarque () kde ! org> X-MARC-Message: https://marc.info/?l=kopete-devel&m=133020009031909 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8904101008457396496==" --===============8904101008457396496== Content-Type: multipart/alternative; boundary="Boundary-01=_x3TSP+wsUHRqk4v" Content-Transfer-Encoding: 7bit --Boundary-01=_x3TSP+wsUHRqk4v Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Em Saturday 25 February 2012, Pali Roh=E1r escreveu: > Hi, >=20 > I'm attaching updated patch. Old patch on reviewboard cannot apply on > kopete from trunk. I tried to update patch also on reviewboard, but I do > not have permission to update it (I'm not author of that review/patch). Well, I think instead of connecting to resumingFromSuspend signal in=20 line QDBusConnection::sessionBus().connect( "org.kde.Solid.PowerManagement",=20 "/org/kde/Solid/PowerManagement", "org.kde.Solid.PowerManagement",=20 "resumingFromSuspend", this, SLOT( resume() ) ); you should connect to statusChanged signal from Solid::Networking. It takes= =20 several seconds to establish Internet connection after the resume, speciall= y=20 for wifi, which is a common case. Checking for Solid::Networking::status()= =20 right after resume will mostly return Solid::Networking::Unknown or=20 Disconnected depending on if the network manager software had started or no= t=20 before Kopete receives the resumingFromSuspend signal. PS: when creating a patch with diff command use --show-c-function option to= =20 show which class method the lines in the patch belongs to. =20 > On Saturday 20 August 2011 09:31:55 Pali Roh=E1r wrote: > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > http://svn.reviewboard.kde.org/r/6511/#review10359 > > ----------------------------------------------------------- > >=20 > >=20 > > I cannot apply this patch on kopete from trunk. Can you update it? > >=20 > > - Pali > >=20 > > On March 1, 2011, 9:39 p.m., alter_schwede wrote: > > > ----------------------------------------------------------- > > > This is an automatically generated e-mail. To reply, visit: > > > http://svn.reviewboard.kde.org/r/6511/ > > > ----------------------------------------------------------- > > >=20 > > > (Updated March 1, 2011, 9:39 p.m.) > > >=20 > > >=20 > > > Review request for Kopete. > > >=20 > > >=20 > > > Summary > > > ------- > > >=20 > > > I already posted this patch here: > > > https://bugs.kde.org/show_bug.cgi?id=3D149544 > > >=20 > > > This patch logs off each account when PC is suspended and restores the > > > online state of each account on resume. This patch also addresses > > > another problem of kopete: When the user was setting kopete to > > > "Offline" and the network connection was lost and recovered kopete > > > would reset all accounts to "Online". > > >=20 > > >=20 > > > This addresses bugs 149544 and 212037. > > >=20 > > > https://bugs.kde.org/show_bug.cgi?id=3D149544 > > > https://bugs.kde.org/show_bug.cgi?id=3D212037 > > >=20 > > > Diffs > > > ----- > > >=20 > > > /branches/KDE/4.6/kdenetwork/kopete/kopete/kopetedbusinterface.h > > > 1222426 > > > /branches/KDE/4.6/kdenetwork/kopete/kopete/kopetedbusinterface.cpp > > > 1222426 > > > /branches/KDE/4.6/kdenetwork/kopete/kopete/org.kde.Kopete.xml 12224= 26 > > > /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccount.h 12224= 26 > > > /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccount.cpp > > > 1222426 > > > /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccountmanager.h > > > 1222426 > > > /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccountmanager.= cp > > > p 1222426> > > >=20 > > > Diff: http://svn.reviewboard.kde.org/r/6511/diff > > >=20 > > >=20 > > > Testing > > > ------- > > >=20 > > >=20 > > > Thanks, > > >=20 > > > alter_schwede =2D-=20 Lamarque V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br --Boundary-01=_x3TSP+wsUHRqk4v Content-Type: text/html; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable

Em Saturday= 25 February 2012, Pali Roh=E1r escreveu:

> Hi,

>

> I'm at= taching updated patch. Old patch on reviewboard cannot apply on

> kopete= from trunk. I tried to update patch also on reviewboard, but I do

> not ha= ve permission to update it (I'm not author of that review/patch).

&nb= sp;

Well, I th= ink instead of connecting to resumingFromSuspend signal in line

&nb= sp;

QDBusConnec= tion::sessionBus().connect( "org.kde.Solid.PowerManagement", &quo= t;/org/kde/Solid/PowerManagement", "org.kde.Solid.PowerManagement= ", "resumingFromSuspend", this, SLOT( resume() ) );

&nb= sp;

you should = connect to statusChanged signal from Solid::Networking. It takes several se= conds to establish Internet connection after the resume, specially for wifi= , which is a common case. Checking for Solid::Networking::status() right af= ter resume will mostly return Solid::Networking::Unknown or Disconnected de= pending on if the network manager software had started or not before Kopete= receives the resumingFromSuspend signal.

&nb= sp;

PS: when cr= eating a patch with diff command use --show-c-function option to show which= class method the lines in the patch belongs to.

> On Sat= urday 20 August 2011 09:31:55 Pali Roh=E1r wrote:

> > -= =2D---------------------------------------------------------

> > T= his is an automatically generated e-mail. To reply, visit:

> > h= ttp://svn.reviewboard.kde.org/r/6511/#review10359

> > -= =2D---------------------------------------------------------

> > <= /p>

> > <= /p>

> > I= cannot apply this patch on kopete from trunk. Can you update it?

> > <= /p>

> > -= Pali

> > <= /p>

> > O= n March 1, 2011, 9:39 p.m., alter_schwede wrote:

> > &= gt; -----------------------------------------------------------

> > &= gt; This is an automatically generated e-mail. To reply, visit:

> > &= gt; http://svn.reviewboard.kde.org/r/6511/

> > &= gt; -----------------------------------------------------------

> > &= gt;

> > &= gt; (Updated March 1, 2011, 9:39 p.m.)

> > &= gt;

> > &= gt;

> > &= gt; Review request for Kopete.

> > &= gt;

> > &= gt;

> > &= gt; Summary

> > &= gt; -------

> > &= gt;

> > &= gt; I already posted this patch here:

> > &= gt; https://bugs.kde.org/show_bug.cgi?id=3D149544

> > &= gt;

> > &= gt; This patch logs off each account when PC is suspended and restores the<= /p>

> > &= gt; online state of each account on resume. This patch also addresses

> > &= gt; another problem of kopete: When the user was setting kopete to

> > &= gt; "Offline" and the network connection was lost and recovered k= opete

> > &= gt; would reset all accounts to "Online".

> > &= gt;

> > &= gt;

> > &= gt; This addresses bugs 149544 and 212037.

> > &= gt;

> > &= gt; https://bugs.kde.org/show_bug.cgi?id=3D149544

> > &= gt; https://bugs.kde.org/show_bug.cgi?id=3D212037

> > &= gt;

> > &= gt; Diffs

> > &= gt; -----

> > &= gt;

> > &= gt; /branches/KDE/4.6/kdenetwork/kopete/kopete/kopetedbusinterface.h

> > &= gt; 1222426

> > &= gt; /branches/KDE/4.6/kdenetwork/kopete/kopete/kopetedbusinterface.cpp

> > &= gt; 1222426

> > &= gt; /branches/KDE/4.6/kdenetwork/kopete/kopete/org.kde.Kopete.xml 1222426=

> > &= gt; /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccount.h 1222426=

> > &= gt; /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccount.cpp

> > &= gt; 1222426

> > &= gt; /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccountmanager.h<= /p>

> > &= gt; 1222426

> > &= gt; /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccountmanager.cp=

> > &= gt; p 1222426>

> > &= gt;

> > &= gt; Diff: http://svn.reviewboard.kde.org/r/6511/diff

> > &= gt;

> > &= gt;

> > &= gt; Testing

> > &= gt; -------

> > &= gt;

> > &= gt;

> > &= gt; Thanks,

> > &= gt;

> > &= gt; alter_schwede

&nb= sp;

&nb= sp;

--

Lamarque V.= Souza

KDE's Netwo= rk Management maintainer

http://plan= etkde.org/pt-br

--Boundary-01=_x3TSP+wsUHRqk4v-- --===============8904101008457396496== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel --===============8904101008457396496==--