[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Re: Review Request: Editor for Jabber Group Chat Bookmarks
From: Pali_Rohár <pali.rohar () gmail ! com>
Date: 2012-02-25 19:33:36
Message-ID: 20120225193336.27733.15227 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6474/#review10697
-----------------------------------------------------------
I found this commit: http://websvn.kde.org/?view=revision&revision=1255055
Is patch in this review commited? If yes, please close this review.
- Pali Rohár
On Feb. 11, 2011, 2:16 p.m., Tobias Koenig wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6474/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2011, 2:16 p.m.)
>
>
> Review request for Kopete.
>
>
> Description
> -------
>
> This patch provides an editor for jabber group chat bookmarks. You can easily remove or \
> rename the bookmarks and (the most important thing IMHO ;)) toggle the auto-join feature of a \
> group chat.
>
> Diffs
> -----
>
> branches/KDE/4.6/kdenetwork/kopete/protocols/jabber/CMakeLists.txt 1219908
> branches/KDE/4.6/kdenetwork/kopete/protocols/jabber/jabberbookmarks.h 1219908
> branches/KDE/4.6/kdenetwork/kopete/protocols/jabber/jabberbookmarks.cpp 1219908
> branches/KDE/4.6/kdenetwork/kopete/protocols/jabber/ui/dlgjabberbookmarkeditor.h PRE-CREATION \
> branches/KDE/4.6/kdenetwork/kopete/protocols/jabber/ui/dlgjabberbookmarkeditor.cpp \
> PRE-CREATION branches/KDE/4.6/kdenetwork/kopete/protocols/jabber/ui/dlgjabberbookmarkeditor.ui \
> PRE-CREATION
> Diff: http://svn.reviewboard.kde.org/r/6474/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tobias Koenig
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6474/">http://svn.reviewboard.kde.org/r/6474/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">I found this commit: \
http://websvn.kde.org/?view=revision&revision=1255055 Is patch in this review commited? If \
yes, please close this review.</pre> <br />
<p>- Pali</p>
<br />
<p>On February 11th, 2011, 2:16 p.m., Tobias Koenig wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for Kopete.</div>
<div>By Tobias Koenig.</div>
<p style="color: grey;"><i>Updated Feb. 11, 2011, 2:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch provides \
an editor for jabber group chat bookmarks. You can easily remove or rename the bookmarks and \
(the most important thing IMHO ;)) toggle the auto-join feature of a group chat.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/KDE/4.6/kdenetwork/kopete/protocols/jabber/CMakeLists.txt <span style="color: \
grey">(1219908)</span></li>
<li>branches/KDE/4.6/kdenetwork/kopete/protocols/jabber/jabberbookmarks.h <span style="color: \
grey">(1219908)</span></li>
<li>branches/KDE/4.6/kdenetwork/kopete/protocols/jabber/jabberbookmarks.cpp <span \
style="color: grey">(1219908)</span></li>
<li>branches/KDE/4.6/kdenetwork/kopete/protocols/jabber/ui/dlgjabberbookmarkeditor.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>branches/KDE/4.6/kdenetwork/kopete/protocols/jabber/ui/dlgjabberbookmarkeditor.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>branches/KDE/4.6/kdenetwork/kopete/protocols/jabber/ui/dlgjabberbookmarkeditor.ui <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6474/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic