'Review Request: Some fixes for cryptography plugin'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Review Request: Some fixes for cryptography plugin
From:       Pali_Rohár <pali.rohar () gmail ! com>
Date:       2011-08-20 8:59:58
Message-ID: 20110820085958.7971.70376 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6768/
-----------------------------------------------------------

Review request for Kopete.

Summary
-------

This patch fix CMAKE_MODULE_PATH in CMakeLists.txt, update supported protoc=
ol lists and update information box about unsupported protocol.

Diffs
-----

  trunk/extragear/network/kopete-cryptography/CMakeLists.txt 1248234 =

  trunk/extragear/network/kopete-cryptography/cryptographyplugin.h 1248234 =

  trunk/extragear/network/kopete-cryptography/cryptographyplugin.cpp 124823=
4 =

Diff: http://svn.reviewboard.kde.org/r/6768/diff

Testing
-------

Patch working for me fine.

Thanks,

Pali

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6768/">http://svn.reviewboard.kde.org/r/6768/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kopete.</div>
<div>By Pali Rohár.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fix CMAKE_MODULE_PATH in CMakeLists.txt, update supported \
protocol lists and update information box about unsupported protocol.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch working for me fine.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/extragear/network/kopete-cryptography/CMakeLists.txt <span style="color: \
grey">(1248234)</span></li>

 <li>trunk/extragear/network/kopete-cryptography/cryptographyplugin.h <span \
style="color: grey">(1248234)</span></li>

 <li>trunk/extragear/network/kopete-cryptography/cryptographyplugin.cpp <span \
style="color: grey">(1248234)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6768/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

[prev in list] [next in list] [prev in thread] [next in thread] 