[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Re: Review Request: Make V4L support optional as it has been removed
From: "Carlos Federico Aguirre" <federico.aguirre () gmail ! com>
Date: 2011-03-27 21:02:54
Message-ID: 20110327210254.5398.9571 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 27, 2011, 7:33 p.m., Lamarque Souza wrote:
> > /trunk/KDE/kdenetwork/kopete/CMakeLists.txt, line 120
> > <http://svn.reviewboard.kde.org/r/6643/diff/1/?file=45869#file45869line120>
> >
> > I did some adjustments in this patch and submitted it. Please close this review request.
Thanks
- Carlos Federico
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6643/#review10036
-----------------------------------------------------------
On March 27, 2011, 6:47 p.m., Carlos Federico Aguirre wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6643/
> -----------------------------------------------------------
>
> (Updated March 27, 2011, 6:47 p.m.)
>
>
> Review request for Kopete.
>
>
> Summary
> -------
>
> it makes v4l support optional.
>
> http://lists.kde.org/?l=kopete-devel&m=129778270415436&w=2
>
>
> This addresses bug 269296.
> https://bugs.kde.org/show_bug.cgi?id=269296
>
>
> Diffs
> -----
>
> /trunk/KDE/kdenetwork/kopete/CMakeLists.txt 1226199
> /trunk/KDE/kdenetwork/kopete/config-kopete.h.cmake 1226199
> /trunk/KDE/kdenetwork/kopete/libkopete/avdevice/videodevice.h 1226199
> /trunk/KDE/kdenetwork/kopete/libkopete/avdevice/videodevice.cpp 1226199
>
> Diff: http://svn.reviewboard.kde.org/r/6643/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Carlos Federico
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6643/">http://svn.reviewboard.kde.org/r/6643/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 27th, 2011, 7:33 p.m., <b>Lamarque \
Souza</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/6643/diff/1/?file=45869#file45869line120" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdenetwork/kopete/CMakeLists.txt</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">120</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">macro_bool_to_01(LIBV4L2_FOUND \
HAVE_LIBV4L2)</pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">120</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">macro_bool_to_01(LIBV4L2_FOUND \
HAVE_LIBV4L2)</pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I did some adjustments \
in this patch and submitted it. Please close this review request.</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Thanks</pre> <br />
<p>- Carlos Federico</p>
<br />
<p>On March 27th, 2011, 6:47 p.m., Carlos Federico Aguirre wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kopete.</div>
<div>By Carlos Federico Aguirre.</div>
<p style="color: grey;"><i>Updated March 27, 2011, 6:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">it makes v4l support optional.
http://lists.kde.org/?l=kopete-devel&m=129778270415436&w=2
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=269296">269296</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdenetwork/kopete/CMakeLists.txt <span style="color: \
grey">(1226199)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/config-kopete.h.cmake <span style="color: \
grey">(1226199)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/libkopete/avdevice/videodevice.h <span \
style="color: grey">(1226199)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/libkopete/avdevice/videodevice.cpp <span \
style="color: grey">(1226199)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6643/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic