'Re: Review Request: Allow inviting users to groupchat by'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: Review Request: Allow inviting users to groupchat by
From:       "Teemu Rytilahti" <tpr () d5k ! net>
Date:       2011-03-24 21:46:58
Message-ID: 20110324214658.20404.16437 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6628/
-----------------------------------------------------------

(Updated March 24, 2011, 9:46 p.m.)

Review request for Kopete.

Summary
-------

Change the dnd mimetype handling from kontact/x-contact & kontact/x-metacontact to \
application/kopete.metacontacts.list only. This is to allow drag'n'dropping from \
contact list to a chatwindow to invite a user, which has worked apparently earlier, \
but for a reason or another the mimetype (and handling too) has been changed.

If someone can clarify that this is ok, it'd be nice.

This addresses bugs 155845 and 214780.
    https://bugs.kde.org/show_bug.cgi?id=155845
    https://bugs.kde.org/show_bug.cgi?id=214780

Diffs
-----

  /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatview.cpp 1225916 

Diff: http://svn.reviewboard.kde.org/r/6628/diff

Testing
-------

Tested to invite a Pidgin user to my own chat, the invite dialog spawns correctly \
inside pidgin and accepting the invitation works too.

Thanks,

Teemu

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6628/">http://svn.reviewboard.kde.org/r/6628/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kopete.</div>
<div>By Teemu Rytilahti.</div>

<p style="color: grey;"><i>Updated March 24, 2011, 9:46 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Change the dnd mimetype handling from kontact/x-contact &amp; \
kontact/x-metacontact to application/kopete.metacontacts.list only. This is to allow \
drag&#39;n&#39;dropping from contact list to a chatwindow to invite a user, which has \
worked apparently earlier, but for a reason or another the mimetype (and handling \
too) has been changed.

If someone can clarify that this is ok, it&#39;d be nice.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested to invite a Pidgin user to my own chat, the invite dialog spawns \
correctly inside pidgin and accepting the invitation works too.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=155845">155845</a>, 

 <a href="https://bugs.kde.org/show_bug.cgi?id=214780">214780</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatview.cpp <span style="color: \
grey">(1225916)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6628/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

[prev in list] [next in list] [prev in thread] [next in thread] 