[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Re: Review Request: Disable notifications in Busy status
From: Pali_Rohár <pali.rohar () gmail ! com>
Date: 2011-03-23 11:02:01
Message-ID: 20110323110201.29109.39340 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6586/
-----------------------------------------------------------
(Updated March 23, 2011, 11:02 a.m.)
Review request for Kopete.
Changes
-------
Updated patch for upstream svn rev.
Summary
-------
This patch disable all visible KNotification for account which is in Busy status.
This addresses bugs 143586, 184113, 205303, and 229306.
https://bugs.kde.org/show_bug.cgi?id=143586
https://bugs.kde.org/show_bug.cgi?id=184113
https://bugs.kde.org/show_bug.cgi?id=205303
https://bugs.kde.org/show_bug.cgi?id=229306
Diffs (updated)
-----
/trunk/KDE/kdenetwork/kopete/kopete/infoeventwidget.cpp 1225642
/trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.cpp 1225642
/trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.cpp 1225642
/trunk/KDE/kdenetwork/kopete/libkopete/kopeteutils.cpp 1225642
/trunk/KDE/kdenetwork/kopete/libkopete/private/kopeteviewmanager.cpp 1225642
/trunk/KDE/kdenetwork/kopete/plugins/otr/authenticationwizard.cpp 1225642
/trunk/KDE/kdenetwork/kopete/plugins/privacy/privacyplugin.cpp 1225642
/trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.cpp 1225642
/trunk/KDE/kdenetwork/kopete/protocols/groupwise/gwaccount.cpp 1225642
/trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 1225642
/trunk/KDE/kdenetwork/kopete/protocols/oscar/icq/icqaccount.cpp 1225642
/trunk/KDE/kdenetwork/kopete/protocols/oscar/icq/icqcontact.cpp 1225642
/trunk/KDE/kdenetwork/kopete/protocols/oscar/oscaraccount.cpp 1225642
/trunk/KDE/kdenetwork/kopete/protocols/skype/libskype/skype.cpp 1225642
/trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp 1225642
/trunk/KDE/kdenetwork/kopete/protocols/yahoo/yahooaccount.cpp 1225642
Diff: http://svn.reviewboard.kde.org/r/6586/diff
Testing
-------
Tested, no notifications are visible when Busy status is selected globaly. So now it \
is real Do not Disturb / Busy status in Kopete (without notifications).
Thanks,
Pali
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6586/">http://svn.reviewboard.kde.org/r/6586/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kopete.</div>
<div>By Pali Rohár.</div>
<p style="color: grey;"><i>Updated March 23, 2011, 11:02 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Updated patch for upstream svn rev.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch disable all visible KNotification for account which is in \
Busy status.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested, no notifications are visible when Busy status is selected \
globaly. So now it is real Do not Disturb / Busy status in Kopete (without \
notifications).</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=143586">143586</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=184113">184113</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=205303">205303</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=229306">229306</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdenetwork/kopete/kopete/infoeventwidget.cpp <span style="color: \
grey">(1225642)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.cpp <span style="color: \
grey">(1225642)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.cpp <span style="color: \
grey">(1225642)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/libkopete/kopeteutils.cpp <span style="color: \
grey">(1225642)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/libkopete/private/kopeteviewmanager.cpp <span \
style="color: grey">(1225642)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/plugins/otr/authenticationwizard.cpp <span \
style="color: grey">(1225642)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/plugins/privacy/privacyplugin.cpp <span \
style="color: grey">(1225642)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.cpp <span style="color: \
grey">(1225642)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/protocols/groupwise/gwaccount.cpp <span \
style="color: grey">(1225642)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp <span \
style="color: grey">(1225642)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/protocols/oscar/icq/icqaccount.cpp <span \
style="color: grey">(1225642)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/protocols/oscar/icq/icqcontact.cpp <span \
style="color: grey">(1225642)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/protocols/oscar/oscaraccount.cpp <span \
style="color: grey">(1225642)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/protocols/skype/libskype/skype.cpp <span \
style="color: grey">(1225642)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp <span style="color: \
grey">(1225642)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/protocols/yahoo/yahooaccount.cpp <span \
style="color: grey">(1225642)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6586/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic