[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Re: Review Request: Do not ask whether to come back from auto-away
From: "Teemu Rytilahti" <tpr () d5k ! net>
Date: 2011-03-22 15:30:08
Message-ID: 20110322153008.18157.48701 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/3260/#review9999
-----------------------------------------------------------
Sorry for being too busy not to commit this one, thankfully lvsouza has com=
mited it now and it should be ok, so I'm putting this to be closed.
- Teemu
On March 12, 2010, 3:03 p.m., Teemu Rytilahti wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/3260/
> -----------------------------------------------------------
> =
> (Updated March 12, 2010, 3:03 p.m.)
> =
> =
> Review request for Kopete.
> =
> =
> Summary
> -------
> =
> This patch modifies the behaviour of idle timer to not to confirm whether=
to come back from auto-away when there are no accounts online. The problem=
before was that I got spammed "Do you want to set yourself as available" w=
hen coming back from away, even if the Kopete was not connected to any serv=
ers.
> =
> As I am not familiar with the codebase, I hope someone can review and see=
whether the approach I'm using here is ok.
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdenetwork/kopete/libkopete/kopeteaccountmanager.h 1101310 =
> /trunk/KDE/kdenetwork/kopete/libkopete/kopetestatusmanager.h 1101310 =
> /trunk/KDE/kdenetwork/kopete/libkopete/kopetestatusmanager.cpp 1101310 =
> =
> Diff: http://svn.reviewboard.kde.org/r/3260/diff
> =
> =
> Testing
> -------
> =
> Tested by using the patched version for a while. Returning from auto-away=
still works just fine when there are accounts connected, but you won't get=
confirmation dialog when coming back when there is no online accounts.
> =
> =
> Thanks,
> =
> Teemu
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/3260/">http://svn.reviewboard.kde.org/r/3260/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry for being too busy \
not to commit this one, thankfully lvsouza has commited it now and it should be ok, \
so I'm putting this to be closed.</pre> <br />
<p>- Teemu</p>
<br />
<p>On March 12th, 2010, 3:03 p.m., Teemu Rytilahti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kopete.</div>
<div>By Teemu Rytilahti.</div>
<p style="color: grey;"><i>Updated March 12, 2010, 3:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch modifies the behaviour of idle timer to not to confirm \
whether to come back from auto-away when there are no accounts online. The problem \
before was that I got spammed "Do you want to set yourself as available" \
when coming back from away, even if the Kopete was not connected to any servers.
As I am not familiar with the codebase, I hope someone can review and see whether the \
approach I'm using here is ok.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested by using the patched version for a while. Returning from \
auto-away still works just fine when there are accounts connected, but you won't \
get confirmation dialog when coming back when there is no online accounts.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdenetwork/kopete/libkopete/kopeteaccountmanager.h <span \
style="color: grey">(1101310)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/libkopete/kopetestatusmanager.h <span style="color: \
grey">(1101310)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/libkopete/kopetestatusmanager.cpp <span \
style="color: grey">(1101310)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/3260/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic