[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Re: Review Request: Properly use KNotification::event
From: "Alexander Potashev" <aspotashev () gmail ! com>
Date: 2011-03-20 18:48:40
Message-ID: 20110320184840.16523.73691 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 20, 2011, 6:26 p.m., Lamarque Souza wrote:
> > trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp, line 1005
> > <http://svn.reviewboard.kde.org/r/6620/diff/1/?file=45655#file45655line1005>
> >
> > I have just commit a slighly different version of this patch. Thanks for pointing \
> > this problem out.
> > Please close this review request.
Thanks.
That was SVN revision 1225401.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6620/#review9995
-----------------------------------------------------------
On March 18, 2011, 3:04 p.m., Alexander Potashev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6620/
> -----------------------------------------------------------
>
> (Updated March 18, 2011, 3:04 p.m.)
>
>
> Review request for Kopete.
>
>
> Summary
> -------
>
> Properly use KNotification::event (the first argument, eventId, should be listed in \
> kopete.notifyrc). Also reduced code duplication.
>
> Diffs
> -----
>
> trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 1225209
>
> Diff: http://svn.reviewboard.kde.org/r/6620/diff
>
>
> Testing
> -------
>
> It builds for me, but I didn't run any tests.
>
>
> Thanks,
>
> Alexander
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6620/">http://svn.reviewboard.kde.org/r/6620/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 20th, 2011, 6:26 p.m., <b>Lamarque \
Souza</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/6620/diff/1/?file=45655#file45655line1005" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
JabberAccount::handleStreamError (int streamError, int streamCondition, int \
connectorCode, const QString &server, Kopete::Account::DisconnectReason \
&errorClass, QString additionalErrMsg)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1005</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">break</span><span class="p">;</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1005</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">break</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have just commit a \
slighly different version of this patch. Thanks for pointing this problem out.
Please close this review request.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks. \
That was SVN revision 1225401.</pre> <br />
<p>- Alexander</p>
<br />
<p>On March 18th, 2011, 3:04 p.m., Alexander Potashev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kopete.</div>
<div>By Alexander Potashev.</div>
<p style="color: grey;"><i>Updated March 18, 2011, 3:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Properly use KNotification::event (the first argument, eventId, should \
be listed in kopete.notifyrc). Also reduced code duplication.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It builds for me, but I didn't run any tests.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp <span \
style="color: grey">(1225209)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6620/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic