[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Re: Review Request: Show emoticons in contactlist
From: "Lamarque Souza" <lamarque () gmail ! com>
Date: 2011-03-11 4:14:11
Message-ID: 20110311041411.5209.17936 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 11, 2010, 9:15 a.m., Roman Jarosz wrote:
> > IIRC the Kopete::Emoticons::tokenize can be/is CPU intensive task, maybe it would \
> > be good to cache it in ContactListModel::metaContactData also if we parse \
> > emoticons in StatusMessageRole we may as well parse it in StatusTitleRole.
I am using this patch for a few days. It works and you right, it is really CPU \
intensive. The froze for a few seconds in my notebook when clicking on the show \
offline users button. I think it would be better we could at least cache the QPixmpa \
generated from the tokens to minimize this problem. Some tokens are still not being \
translated though, for instance [c=...] [/c] [b] [/b] [u] [u]
- Lamarque
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/2542/#review3650
-----------------------------------------------------------
On Jan. 14, 2010, 5:44 p.m., Stefan Geuns wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/2542/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2010, 5:44 p.m.)
>
>
> Review request for Kopete.
>
>
> Summary
> -------
>
> The contactlist no longer shows emoticons in recent kopete versions. This patch \
> re-enables this feature for both the contacts their display name and status \
> message.
> In the contactlist drawing code I noticed a bug with the drawing of \
> ContactList::LayoutManager::PlaceHolder, "value == " was missing (twice). This \
> patch also fixed that.
>
> Diffs
> -----
>
> /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistmodel.h 1073101
> /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistmodel.cpp 1073101
> /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitemdelegate.cpp 1073101
>
> Diff: http://svn.reviewboard.kde.org/r/2542/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Stefan
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/2542/">http://svn.reviewboard.kde.org/r/2542/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 11th, 2010, 9:15 a.m., <b>Roman \
Jarosz</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">IIRC the Kopete::Emoticons::tokenize can be/is CPU intensive task, maybe \
it would be good to cache it in ContactListModel::metaContactData also if we parse \
emoticons in StatusMessageRole we may as well parse it in StatusTitleRole.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am using this patch \
for a few days. It works and you right, it is really CPU intensive. The froze for a \
few seconds in my notebook when clicking on the show offline users button. I think it \
would be better we could at least cache the QPixmpa generated from the tokens to \
minimize this problem. Some tokens are still not being translated though, for \
instance [c=...] [/c] [b] [/b] [u] [u]</pre> <br />
<p>- Lamarque</p>
<br />
<p>On January 14th, 2010, 5:44 p.m., Stefan Geuns wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kopete.</div>
<div>By Stefan Geuns.</div>
<p style="color: grey;"><i>Updated Jan. 14, 2010, 5:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The contactlist no longer shows emoticons in recent kopete versions. \
This patch re-enables this feature for both the contacts their display name and \
status message.
In the contactlist drawing code I noticed a bug with the drawing of \
ContactList::LayoutManager::PlaceHolder, "value == " was missing (twice). \
This patch also fixed that.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistmodel.h <span \
style="color: grey">(1073101)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistmodel.cpp <span \
style="color: grey">(1073101)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitemdelegate.cpp <span \
style="color: grey">(1073101)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/2542/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic