[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Re: Review Request: Enable LaTeX plugin when you check ;
From: "Lamarque Souza" <lamarque () gmail ! com>
Date: 2011-03-05 18:56:59
Message-ID: 20110305185659.17121.96120 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/2462/#review9955
-----------------------------------------------------------
/trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmessagepart.h
<http://svn.reviewboard.kde.org/r/2462/#comment11158>
Patch applied to trunk, please close this review request.
- Lamarque
On Dec. 30, 2009, 10:48 a.m., Fabian Rami wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/2462/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2009, 10:48 a.m.)
>
>
> Review request for Kopete.
>
>
> Summary
> -------
>
> Solve the problem of the latex plugin.
> If other plugin have the same problem, they can emit signal toggleGraphicOverride \
> to chat session to resolv it.
> It's a Junior Job so every critics are welcome.
>
>
> This addresses bug 217277.
> https://bugs.kde.org/show_bug.cgi?id=217277
>
>
> Diffs
> -----
>
> /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmessagepart.h 1067675
> /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmessagepart.cpp 1067675
> /trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.h 1067675
> /trunk/KDE/kdenetwork/kopete/plugins/latex/latexplugin.h 1067675
> /trunk/KDE/kdenetwork/kopete/plugins/latex/latexplugin.cpp 1067675
>
> Diff: http://svn.reviewboard.kde.org/r/2462/diff
>
>
> Testing
> -------
>
> Setup :
> - enable LaTeX plugin
> - in kopete setting-> chat window -> colors & fonts check do not show user \
> specified rich text
> Before patching :
> - send a message : plugin LaTeX $$LaTeX encapsuled$$
> - on booth window you see that the message don't come with LaTeX
> - If you go uncheck do not show user specified rich text, the LaTeX apear
>
> After patching :
> - send a message : plugin LaTeX $$LaTeX encapsuled$$
> - on booth window you see that the message come with LaTeX Enabled
>
> I do my test under Gentoo / KDE-Svn trunk
>
>
> Thanks,
>
> Fabian
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/2462/">http://svn.reviewboard.kde.org/r/2462/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/2462/diff/1/?file=16275#file16275line1" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmessagepart.h</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm">/*</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1</font></th> \
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "><span class="cm">/*</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch \
applied to trunk, please close this review request.</pre> </div>
<br />
<p>- Lamarque</p>
<br />
<p>On December 30th, 2009, 10:48 a.m., Fabian Rami wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kopete.</div>
<div>By Fabian Rami.</div>
<p style="color: grey;"><i>Updated Dec. 30, 2009, 10:48 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Solve the problem of the latex plugin. If other plugin have the same \
problem, they can emit signal toggleGraphicOverride to chat session to resolv it.
It's a Junior Job so every critics are welcome.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Setup :
- enable LaTeX plugin
- in kopete setting-> chat window -> colors & fonts check do not show user \
specified rich text
Before patching :
- send a message : plugin LaTeX $$LaTeX encapsuled$$
- on booth window you see that the message don't come with LaTeX
- If you go uncheck do not show user specified rich text, the LaTeX apear
After patching :
- send a message : plugin LaTeX $$LaTeX encapsuled$$
- on booth window you see that the message come with LaTeX Enabled
I do my test under Gentoo / KDE-Svn trunk
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=217277">217277</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmessagepart.h <span \
style="color: grey">(1067675)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmessagepart.cpp <span \
style="color: grey">(1067675)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.h <span style="color: \
grey">(1067675)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/plugins/latex/latexplugin.h <span style="color: \
grey">(1067675)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/plugins/latex/latexplugin.cpp <span style="color: \
grey">(1067675)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/2462/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic