[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Review Request: Fix "last seen" property when ungracefully exiting
From: "Martin Blumenstingl" <darklight.xdarklight () googlemail ! com>
Date: 2011-03-04 20:10:12
Message-ID: 20110304201012.26851.48470 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6581/
-----------------------------------------------------------
Review request for Kopete.
Summary
-------
This patch fixes another problem with kopete's "Last Seen" feature.
If a contact was online when you CTRL-C kopete (or shutdown your computer) no "last \
seen" time is shown for the contact (once kopete is started again and the given \
contact is offline then).
The reason was quite obvious:
kopete did not do a clean shutdown when getting SIGTERM/SIGINT
I implemented a simple signal handler which takes care of the SIGTERM/SIGINT signals.
NOTE: This patch depends on this one: http://svn.reviewboard.kde.org/r/6526/
This addresses bug 267654.
https://bugs.kde.org/show_bug.cgi?id=267654
Diffs
-----
/trunk/KDE/kdenetwork/kopete/kopete/main.cpp 1223740
Diff: http://svn.reviewboard.kde.org/r/6581/diff
Testing
-------
I CTRL-C'ed kopete and asked a buddy to go offline.
His "Last seen" property was correctly shown once I started kopete again.
NOTE: This patch depends on this one: http://svn.reviewboard.kde.org/r/6526/
Thanks,
Martin
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6581/">http://svn.reviewboard.kde.org/r/6581/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kopete.</div>
<div>By Martin Blumenstingl.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fixes another problem with kopete's "Last Seen" \
feature.
If a contact was online when you CTRL-C kopete (or shutdown your computer) no \
"last seen" time is shown for the contact (once kopete is started again and \
the given contact is offline then).
The reason was quite obvious:
kopete did not do a clean shutdown when getting SIGTERM/SIGINT
I implemented a simple signal handler which takes care of the SIGTERM/SIGINT signals.
NOTE: This patch depends on this one: http://svn.reviewboard.kde.org/r/6526/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I CTRL-C'ed kopete and asked a buddy to go offline. His "Last \
seen" property was correctly shown once I started kopete again.
NOTE: This patch depends on this one: http://svn.reviewboard.kde.org/r/6526/</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=267654">267654</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdenetwork/kopete/kopete/main.cpp <span style="color: \
grey">(1223740)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6581/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic