'Re: Review Request: Wrong use of account->myself() in'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: Review Request: Wrong use of account->myself() in
From:       alter_schwede () bossmail ! de
Date:       2011-03-01 21:31:19
Message-ID: 20110301213119.9920.55723 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6544/
-----------------------------------------------------------

(Updated March 1, 2011, 9:31 p.m.)

Review request for Kopete.

Summary (updated)
-------

In jabbercontact.cpp line 87:
* Note: The only time account->myself() could be a
* NULL pointer is if this contact here is the myself()
* instance itself. Since in that case we wouldn't
* get updates at all, we need to treat that as a
* special case.

So to check if this contact is the myself contact of an account, you would =
use
if ( !account->myself() )
(Because when the myself contact is created it can't already be set as the =
myself contact of the account.)

So I think that the comments in line 98 and 105 should be interchanged (as =
in diff r2).

Can someone confirm this?

Diffs
-----

  /branches/KDE/4.6/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp 12=
22695 =

Diff: http://svn.reviewboard.kde.org/r/6544/diff

Testing
-------

Thanks,

alter_schwede

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6544/">http://svn.reviewboard.kde.org/r/6544/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kopete.</div>
<div>By alter_schwede.</div>

<p style="color: grey;"><i>Updated March 1, 2011, 9:31 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">In jabbercontact.cpp line 87:
* Note: The only time account-&gt;myself() could be a
* NULL pointer is if this contact here is the myself()
* instance itself. Since in that case we wouldn&#39;t
* get updates at all, we need to treat that as a
* special case.

So to check if this contact is the myself contact of an account, you would use
if ( !account-&gt;myself() )
(Because when the myself contact is created it can&#39;t already be set as the myself \
contact of the account.)

So I think that the comments in line 98 and 105 should be interchanged (as in diff \
r2).

Can someone confirm this?</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/KDE/4.6/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp <span \
style="color: grey">(1222695)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6544/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

[prev in list] [next in list] [prev in thread] [next in thread] 