[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Re: Review Request: Kopete: Automatically logout and login with
From: alter_schwede () bossmail ! de
Date: 2011-03-01 20:57:52
Message-ID: 20110301205752.8481.29402 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 28, 2011, 5:30 p.m., alter_schwede wrote:
> > /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccount.cpp, line 562
> > <http://svn.reviewboard.kde.org/r/6511/diff/6/?file=45213#file45213line562>
> >
> > I think we have to make sure that this is the myself account, don't we? And how?
I think you can ignore my last comment. I confused it with the myself contact.
- alter_schwede
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6511/#review9920
-----------------------------------------------------------
On Feb. 23, 2011, 6:58 p.m., alter_schwede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6511/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2011, 6:58 p.m.)
>
>
> Review request for Kopete.
>
>
> Summary
> -------
>
> I already posted this patch here:
> https://bugs.kde.org/show_bug.cgi?id=149544
>
> This patch logs off each account when PC is suspended and restores the online state \
> of each account on resume. This patch also addresses another problem of kopete: \
> When the user was setting kopete to "Offline" and the network connection was lost \
> and recovered kopete would reset all accounts to "Online".
>
> This addresses bug 149544.
> https://bugs.kde.org/show_bug.cgi?id=149544
>
>
> Diffs
> -----
>
> /branches/KDE/4.6/kdenetwork/kopete/kopete/kopetedbusinterface.h 1222426
> /branches/KDE/4.6/kdenetwork/kopete/kopete/kopetedbusinterface.cpp 1222426
> /branches/KDE/4.6/kdenetwork/kopete/kopete/org.kde.Kopete.xml 1222426
> /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccount.h 1222426
> /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccount.cpp 1222426
> /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccountmanager.h 1222426
> /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccountmanager.cpp 1222426
>
> Diff: http://svn.reviewboard.kde.org/r/6511/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> alter_schwede
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6511/">http://svn.reviewboard.kde.org/r/6511/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 28th, 2011, 5:30 p.m., \
<b>alter_schwede</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: \
2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/6511/diff/6/?file=45213#file45213line562" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccount.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 6)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">bool Account::suspend( const Kopete::StatusMessage &reason )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">562</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span> <span class="n">d</span><span \
class="o">-></span><span class="n">suspended</span> <span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think we have to make \
sure that this is the myself account, don't we? And how?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think you \
can ignore my last comment. I confused it with the myself contact.</pre> <br />
<p>- alter_schwede</p>
<br />
<p>On February 23rd, 2011, 6:58 p.m., alter_schwede wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kopete.</div>
<div>By alter_schwede.</div>
<p style="color: grey;"><i>Updated Feb. 23, 2011, 6:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I already posted this patch here: \
https://bugs.kde.org/show_bug.cgi?id=149544
This patch logs off each account when PC is suspended and restores the online state \
of each account on resume. This patch also addresses another problem of kopete: When \
the user was setting kopete to "Offline" and the network connection was \
lost and recovered kopete would reset all accounts to "Online". </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=149544">149544</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/KDE/4.6/kdenetwork/kopete/kopete/kopetedbusinterface.h <span \
style="color: grey">(1222426)</span></li>
<li>/branches/KDE/4.6/kdenetwork/kopete/kopete/kopetedbusinterface.cpp <span \
style="color: grey">(1222426)</span></li>
<li>/branches/KDE/4.6/kdenetwork/kopete/kopete/org.kde.Kopete.xml <span \
style="color: grey">(1222426)</span></li>
<li>/branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccount.h <span \
style="color: grey">(1222426)</span></li>
<li>/branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccount.cpp <span \
style="color: grey">(1222426)</span></li>
<li>/branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccountmanager.h <span \
style="color: grey">(1222426)</span></li>
<li>/branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccountmanager.cpp <span \
style="color: grey">(1222426)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6511/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic