[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Re: Review Request: Fix "last seen" property when an account goes
From: "Martin Blumenstingl" <darklight.xdarklight () googlemail ! com>
Date: 2011-02-18 1:56:53
Message-ID: 20110218015653.7531.94717 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 17, 2011, 8:41 p.m., Raphael Kubo da Costa wrote:
> > Can you also backport and update the 4.6 changelog accordingly?
Committed (r1221356) and backported to 4.6 (r1221356).
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6448/#review9874
-----------------------------------------------------------
On Feb. 18, 2011, 1:46 a.m., Martin Blumenstingl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6448/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2011, 1:46 a.m.)
>
>
> Review request for Kopete.
>
>
> Summary
> -------
>
> This patch fixes a problem with kopete's "Last Seen" feature.
>
> See the following use-case:
> -Contact::setOnlineStatus() sets the last seen date of a user
> -if a user goes online the "last seen" property will be removed (and "online since" \
> will be added)
> -if a user goes offline the "last seen" property is set (with the current \
> date/time)
> -if your account goes offline then nothing is done for the account's contacts
>
> If user X was still online when account Y got disconnected the "Last Seen" property \
> was not written.
> The solution was quite trivial:
> Once an account goes offline all of it's contacts have to be marked as offline too.
>
> My patch should not change behavior in kopete.
> Contact::setOnlineStatus() still does not emit onlineStatusChanged() as \
> account->isConnected() is false. Notifications are also not shown, as \
> Account::setAllContactsStatus() ensures that notifications are disabled for 5 \
> seconds.
>
> This addresses bug 266580.
> https://bugs.kde.org/show_bug.cgi?id=266580
>
>
> Diffs
> -----
>
> /trunk/KDE/kdenetwork/kopete/libkopete/kopeteaccount.cpp 1219168
>
> Diff: http://svn.reviewboard.kde.org/r/6448/diff
>
>
> Testing
> -------
>
> -"Last Seen" is now written correctly
> -"Online Since" is still shown correctly
>
>
> Thanks,
>
> Martin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6448/">http://svn.reviewboard.kde.org/r/6448/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 17th, 2011, 8:41 p.m., <b>Raphael Kubo \
da Costa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Can you also backport and update the 4.6 changelog accordingly?</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Committed (r1221356) and \
backported to 4.6 (r1221356).</pre> <br />
<p>- Martin</p>
<br />
<p>On February 18th, 2011, 1:46 a.m., Martin Blumenstingl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kopete.</div>
<div>By Martin Blumenstingl.</div>
<p style="color: grey;"><i>Updated Feb. 18, 2011, 1:46 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fixes a problem with kopete's "Last Seen" \
feature.
See the following use-case:
-Contact::setOnlineStatus() sets the last seen date of a user
-if a user goes online the "last seen" property will be removed (and \
"online since" will be added)
-if a user goes offline the "last seen" property is set (with the current \
date/time)
-if your account goes offline then nothing is done for the account's contacts
If user X was still online when account Y got disconnected the "Last Seen" \
property was not written.
The solution was quite trivial:
Once an account goes offline all of it's contacts have to be marked as offline \
too.
My patch should not change behavior in kopete.
Contact::setOnlineStatus() still does not emit onlineStatusChanged() as \
account->isConnected() is false. Notifications are also not shown, as \
Account::setAllContactsStatus() ensures that notifications are disabled for 5 \
seconds.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">-"Last Seen" is now written correctly
-"Online Since" is still shown correctly
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=266580">266580</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdenetwork/kopete/libkopete/kopeteaccount.cpp <span style="color: \
grey">(1219168)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6448/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic