'Re: Review Request: Kopete: Automatically logout and login with'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: Review Request: Kopete: Automatically logout and login with
From:       alter_schwede () bossmail ! de
Date:       2011-02-17 20:02:57
Message-ID: 20110217200257.26996.8259 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6511/
-----------------------------------------------------------

(Updated Feb. 17, 2011, 8:02 p.m.)

Review request for Kopete.

Summary
-------

I already posted this patch here:
https://bugs.kde.org/show_bug.cgi?id=149544

This patch logs off each account when PC is suspended and restores the online state \
of each account on resume. This patch also addresses another problem of kopete: When \
the user was setting kopete to "Offline" and the network connection was lost and \
recovered kopete would reset all accounts to "Online".

This addresses bug 149544.
    https://bugs.kde.org/show_bug.cgi?id=149544

Diffs
-----

  /branches/KDE/4.6/kdenetwork/kopete/kopete/kopetedbusinterface.h 1219275 
  /branches/KDE/4.6/kdenetwork/kopete/kopete/kopetedbusinterface.cpp 1219275 
  /branches/KDE/4.6/kdenetwork/kopete/kopete/org.kde.Kopete.xml 1219275 
  /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccount.h 1219275 
  /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccount.cpp 1219275 
  /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccountmanager.h 1219275 
  /branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccountmanager.cpp 1219275 

Diff: http://svn.reviewboard.kde.org/r/6511/diff

Testing
-------

Thanks,

alter_schwede

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6511/">http://svn.reviewboard.kde.org/r/6511/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kopete.</div>
<div>By alter_schwede.</div>

<p style="color: grey;"><i>Updated Feb. 17, 2011, 8:02 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I already posted this patch here: \
https://bugs.kde.org/show_bug.cgi?id=149544

This patch logs off each account when PC is suspended and restores the online state \
of each account on resume. This patch also addresses another problem of kopete: When \
the user was setting kopete to &quot;Offline&quot; and the network connection was \
lost and recovered kopete would reset all accounts to &quot;Online&quot;. </pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=149544">149544</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/KDE/4.6/kdenetwork/kopete/kopete/kopetedbusinterface.h <span \
style="color: grey">(1219275)</span></li>

 <li>/branches/KDE/4.6/kdenetwork/kopete/kopete/kopetedbusinterface.cpp <span \
style="color: grey">(1219275)</span></li>

 <li>/branches/KDE/4.6/kdenetwork/kopete/kopete/org.kde.Kopete.xml <span \
style="color: grey">(1219275)</span></li>

 <li>/branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccount.h <span \
style="color: grey">(1219275)</span></li>

 <li>/branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccount.cpp <span \
style="color: grey">(1219275)</span></li>

 <li>/branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccountmanager.h <span \
style="color: grey">(1219275)</span></li>

 <li>/branches/KDE/4.6/kdenetwork/kopete/libkopete/kopeteaccountmanager.cpp <span \
style="color: grey">(1219275)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6511/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

[prev in list] [next in list] [prev in thread] [next in thread] 