[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Re: Review Request: Rich html messages in history
From: Pali_Rohár <pali.rohar () gmail ! com>
Date: 2010-12-28 14:12:15
Message-ID: 20101228141215.26079.62964 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-12-28 10:26:58, Raphael Kubo da Costa wrote:
> > Haven't tested it, but the code looks OK. Does it close any bug report?
I did not found any bug report.
- Pali
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6053/#review9437
-----------------------------------------------------------
On 2010-12-05 16:23:03, Pali Roh=C3=A1r wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6053/
> -----------------------------------------------------------
> =
> (Updated 2010-12-05 16:23:03)
> =
> =
> Review request for Kopete.
> =
> =
> Summary
> -------
> =
> This patch add support for storing rich html messages in history. Before,=
all messages was first converted to plaintext and then saved in history pl=
ugin. Now html messages are saved in html format and are not converted to p=
laintext.
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdenetwork/kopete/plugins/history/historylogger.cpp 1203573 =
> =
> Diff: http://svn.reviewboard.kde.org/r/6053/diff
> =
> =
> Testing
> -------
> =
> Old history is loaded and displayed correctly.
> Messages in plaintext with user writed html tags (If user write plaintext=
message which contains < > & ... in chatwindow) are displayed correctly.
> Messages in html with < & ... are displayed correctly too.
> =
> =
> Thanks,
> =
> Pali
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6053/">http://svn.reviewboard.kde.org/r/6053/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 28th, 2010, 10:26 a.m., <b>Raphael \
Kubo da Costa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Haven't tested it, but the code looks OK. Does it close any bug \
report?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I did not found any bug \
report.</pre> <br />
<p>- Pali</p>
<br />
<p>On December 5th, 2010, 4:23 p.m., Pali Rohár wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kopete.</div>
<div>By Pali Rohár.</div>
<p style="color: grey;"><i>Updated 2010-12-05 16:23:03</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch add support for storing rich html messages in history. \
Before, all messages was first converted to plaintext and then saved in history \
plugin. Now html messages are saved in html format and are not converted to \
plaintext.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Old history is loaded and displayed correctly. Messages in plaintext \
with user writed html tags (If user write plaintext message which contains < > \
& ... in chatwindow) are displayed correctly. Messages in html with &lt \
&amp ... are displayed correctly too.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdenetwork/kopete/plugins/history/historylogger.cpp <span \
style="color: grey">(1203573)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6053/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic