[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Review Request: Add notifications about contact's status message
From: "Igor Poboiko" <igor.poboiko () gmail ! com>
Date: 2010-09-07 20:37:06
Message-ID: 20100907203706.6501.94046 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5282/
-----------------------------------------------------------
Review request for Kopete.
Summary
-------
This patch adds notifications about status message in kopete chatwindow about \
contact's changed status message. It also fixes bug 160510 when status doesn't \
change, but kopete shows an notification about it.
This addresses bugs 160510 and 193402.
https://bugs.kde.org/show_bug.cgi?id=160510
https://bugs.kde.org/show_bug.cgi?id=193402
Diffs
-----
/trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatview.h 1172680
/trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatview.cpp 1172680
/trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.h 1172680
/trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.cpp 1172680
/trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.h 1172680
/trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.cpp 1172680
/trunk/KDE/kdenetwork/kopete/protocols/oscar/aim/aimuserinfo.cpp 1172680
/trunk/KDE/kdenetwork/kopete/protocols/oscar/icq/icqcontact.cpp 1172680
/trunk/KDE/kdenetwork/kopete/protocols/oscar/icqcontactbase.cpp 1172680
/trunk/KDE/kdenetwork/kopete/protocols/oscar/oscarcontact.h 1172680
/trunk/KDE/kdenetwork/kopete/protocols/oscar/oscarcontact.cpp 1172680
Diff: http://svn.reviewboard.kde.org/r/5282/diff
Testing
-------
Kopete from trunk compiles fine with it. It shows notifications for every user in \
chat (except the ones who haven't status messages). There is one problem: if user \
changes Xtraz status, it shows two notifications (because oscar protocol sends a \
message with status message, then kopete asks user about his status message and then \
sets it one more time - see attached screenshot). I don't know what to do with it. \
Suggestions are welcome.
Screenshots
-----------
Chat window (Hacker theme)
http://svn.reviewboard.kde.org/r/5282/s/500/
Thanks,
Igor
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5282/">http://svn.reviewboard.kde.org/r/5282/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kopete.</div>
<div>By Igor Poboiko.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds notifications about status message in kopete chatwindow \
about contact's changed status message. It also fixes bug 160510 when status \
doesn't change, but kopete shows an notification about it.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Kopete from trunk compiles fine with it. It shows notifications for \
every user in chat (except the ones who haven't status messages). There is one \
problem: if user changes Xtraz status, it shows two notifications (because oscar \
protocol sends a message with status message, then kopete asks user about his status \
message and then sets it one more time - see attached screenshot). I don't know \
what to do with it. Suggestions are welcome.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=160510">160510</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=193402">193402</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatview.h <span style="color: \
grey">(1172680)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatview.cpp <span style="color: \
grey">(1172680)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.h <span style="color: \
grey">(1172680)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.cpp <span style="color: \
grey">(1172680)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.h <span style="color: \
grey">(1172680)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.cpp <span style="color: \
grey">(1172680)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/protocols/oscar/aim/aimuserinfo.cpp <span \
style="color: grey">(1172680)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/protocols/oscar/icq/icqcontact.cpp <span \
style="color: grey">(1172680)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/protocols/oscar/icqcontactbase.cpp <span \
style="color: grey">(1172680)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/protocols/oscar/oscarcontact.h <span style="color: \
grey">(1172680)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/protocols/oscar/oscarcontact.cpp <span \
style="color: grey">(1172680)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5282/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5282/s/500/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/07/statusmessage_400x100.png" \
style="border: 1px black solid;" alt="Chat window (Hacker theme)" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic