[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Re: Review Request: Fix systray icons missing
From: "Lamarque Souza" <lamarque () gmail ! com>
Date: 2010-09-04 23:29:30
Message-ID: 20100904232930.27897.77294 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5226/
-----------------------------------------------------------
(Updated 2010-09-04 23:29:29.889730)
Review request for Kopete.
Changes
-------
Icon path method moved to Kopete::Account (libkopete). If there is nothing more to do \
I will commit this patch tomorrow.
Summary
-------
This patch fix systray icons missing reported by bug 222689. The add adds the \
account's picture to the tooltip, if the icon is not available it adds the protocol \
icon instead.
The original problem is that the file handle 'kopete-account-icon:x:y' in img \
src=\"kopete-account-icon:%3:%4\"> does not work with KStatusNotifierItem, that is a \
problem for other KDE programs too. Maybe it is better fix KStatusNotifierItem \
instead, maybe add a 'icon:/' file handle to it, so that every KDE program could use \
icons in system tray tooltip.
This addresses bug 222689.
https://bugs.kde.org/show_bug.cgi?id=222689
Diffs (updated)
-----
/trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.cpp 1170480
/trunk/KDE/kdenetwork/kopete/libkopete/kopeteaccount.h 1043415
/trunk/KDE/kdenetwork/kopete/libkopete/kopeteaccount.cpp 1067404
Diff: http://svn.reviewboard.kde.org/r/5226/diff
Testing
-------
Screenshots
-----------
Old version
http://svn.reviewboard.kde.org/r/5226/s/492/
New version
http://svn.reviewboard.kde.org/r/5226/s/494/
Thanks,
Lamarque
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5226/">http://svn.reviewboard.kde.org/r/5226/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kopete.</div>
<div>By Lamarque Souza.</div>
<p style="color: grey;"><i>Updated 2010-09-04 23:29:29.889730</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Icon path method moved to Kopete::Account (libkopete). If there is \
nothing more to do I will commit this patch tomorrow.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fix systray icons missing reported by bug 222689. The add \
adds the account's picture to the tooltip, if the icon is not available it adds \
the protocol icon instead.
The original problem is that the file handle 'kopete-account-icon:x:y' in img \
src=\"kopete-account-icon:%3:%4\"> does not work with \
KStatusNotifierItem, that is a problem for other KDE programs too. Maybe it is better \
fix KStatusNotifierItem instead, maybe add a 'icon:/' file handle to it, so \
that every KDE program could use icons in system tray tooltip.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=222689">222689</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.cpp <span style="color: \
grey">(1170480)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/libkopete/kopeteaccount.h <span style="color: \
grey">(1043415)</span></li>
<li>/trunk/KDE/kdenetwork/kopete/libkopete/kopeteaccount.cpp <span style="color: \
grey">(1067404)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5226/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5226/s/492/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/01/kopete_after_400x100.png" \
style="border: 1px black solid;" alt="Old version" /></a>
<a href="http://svn.reviewboard.kde.org/r/5226/s/494/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/04/kopete_with_icons_400x100.jpg" \
style="border: 1px black solid;" alt="New version" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic