[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: KDE/kdenetwork/kopete/protocols/oscar/icq/ui
From:       Olivier Goffart <ogoffart () kde ! org>
Date:       2010-06-15 20:39:47
Message-ID: 201006152239.48031.ogoffart () kde ! org
[Download RAW message or body]

Le Tuesday 15 June 2010, Tomáš Trnka a écrit :
> Dne Út 15. června 2010 Nick Shaforostoff napsal(a):
> (snip)
> >     mAccount = new ICQAccount(mProtocol, mAccountSettings->edtAccountId
> > -   if(!mAccount)
> > -       return NULL;
 
> Hello,
> 
> do we really want this? All hell will break loose as soon as anyone builds
> without exceptions (quite probable IMHO because of KDE being the "land of
> no exceptions").

Apart from the "dont touch if its not broken" reason, there is really no point 
checking if new succeeded. It is just a waste of CPU cycles.

(The default allocator never returns 0. And even if it did, we would crash 
anyway somewhere else.)

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

[prev in list] [next in list] [prev in thread] [next in thread]