[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: Review Request: Correctly calculate the sizeHint (height) of the
From:       "Raphael Kubo da Costa" <kubito () gmail ! com>
Date:       2010-05-16 22:10:25
Message-ID: 20100516221025.5988.97952 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3989/#review5686
-----------------------------------------------------------


I don't really know this code, but judging from your screenshots it seems to work \
fine. I think if nobody objects, you can commit and backport it (remember to update \
trunk/www/sites/www/announcements/changelogs/changelog_branch_4_4.xml too).

- Raphael


On 2010-05-16 06:06:59, Christian Muehlhaeuser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3989/
> -----------------------------------------------------------
> 
> (Updated 2010-05-16 06:06:59)
> 
> 
> Review request for Kopete.
> 
> 
> Summary
> -------
> 
> Fixes bug 234002: Sizing (height) issues with the identity / account list.
> 
> Problem: The ItemDelegate's sizeHint() doesn't return the actual space required for \
> each row in the QListWidget. Fixed by: Relying on QListWidget's sizeHintForRow() to \
> calculate the actual size of the widget. 
> See screenshots, please... they are pretty much self-explanatory.
> 
> Thanks for reviewing,
> Chris
> 
> 
> This addresses bug 234002.
> https://bugs.kde.org/show_bug.cgi?id=234002
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdenetwork/kopete/kopete/identity/identitystatuswidget.cpp 1125226 
> 
> Diff: http://reviewboard.kde.org/r/3989/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> After fix.
> http://reviewboard.kde.org/r/3989/s/395/
> Before fix.
> http://reviewboard.kde.org/r/3989/s/396/
> 
> 
> Thanks,
> 
> Christian
> 
> 

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]