[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Review Request: kopete chatmemberlistmodel
From:       cyberbeat () gmx ! de
Date:       2009-10-30 14:37:28
Message-ID: 20091030143728.20953.18561 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1862/
-----------------------------------------------------------

(Updated 2009-10-30 14:37:27.946772)


Review request for Kopete and Matt Rogers.


Changes
-------

I have now done the little changes. One last (big?) problem: this diff is against 4.3 \
branch. I have no trunk build, and will not use kde trunk on my pc (pc is very slow).

a) may I commit it to 4.3 branch?
b) may someone else make it work in trunk? (the files should not have changed much I \
think)


Summary
-------

- Changed the chatmemberlistmodel so that it sorts the contacts by \
                onlinestatus-weight/nickname (important for IRC).
- chatmemberlistmodel manages it's own sorted list of contacts
- implemented the "FIXME"s so that the add/remove slots do not call "reset()" \
                anymore, which takes a lot of time for big irc channels
- added signal/slot for nickname-change to chatsession (model needs to know for \
resorting)


Diffs (updated)
-----

  /branches/KDE/4.3/kdenetwork/kopete/kopete/chatwindow/chattexteditpart.cpp 1026738 
  /branches/KDE/4.3/kdenetwork/kopete/kopete/chatwindow/chatview.cpp 1026738 
  /branches/KDE/4.3/kdenetwork/kopete/libkopete/chatsessionmemberslistmodel.h 1035610 \
  /branches/KDE/4.3/kdenetwork/kopete/libkopete/chatsessionmemberslistmodel.cpp \
1035610   /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetechatsession.h 1035610 
  /branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetechatsession.cpp 1035610 

Diff: http://reviewboard.kde.org/r/1862/diff


Testing
-------

works for me with IRC, ICQ,..


Screenshots
-----------

IRC with sorted members
  http://reviewboard.kde.org/r/1862/s/228/


Thanks,

Cyberbeat

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]