[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Review Request: Ability to show individuals
From:       "Bruno Bigras" <bigras.bruno () gmail ! com>
Date:       2009-10-15 15:23:53
Message-ID: 20091015152353.17927.34104 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1619/
-----------------------------------------------------------

(Updated 2009-10-15 15:23:53.285176)


Review request for Kopete.


Changes
-------

Here's a new diff without using the XML file.

I added a kaction in the context menu which use setProperty(). It would have made \
more sense if the metacontact could be set as "always visible" because I don't think \
it makes sense that a metacontact can have two contacts which both have this option \
but it's only show once. But if I'm right metacontact don't have setProperty().

For now the kaction don't have a checkbox because I wanted to be sure I was doing it \
the right way. When triggering this action the contact list is not refreshed at this \
time.

I am note sure if it's right because I made modification in the libkopete which may \
be the frozen API you were talking about. Unless you were only talking about the XML \
part.


Summary
-------

Add the possibility to always show a contact even if offline like in Pidgin. It makes \
sending messages to "always invisible" friends much easier when having many contacts.

For now, it adds a "always-visible" tag in contactlist.xml.

    <meta-contact kabcId="WlmProtocol:my@email.com:someone@iknow.com" \
contactId="{ef566dff-e12c-41e6-8390-c0a46666319e}" >  <display-name></display-name>
        <always-visible>false</always-visible>


This addresses bug 98757.
    https://bugs.kde.org/show_bug.cgi?id=98757


Diffs (updated)
-----

  /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistproxymodel.cpp 1035504 
  /trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlisttreemodel.cpp 1035504 
  /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitembase.h 1035504 
  /trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.h 1035504 
  /trunk/KDE/kdenetwork/kopete/libkopete/kopetecontact.cpp 1035504 
  /trunk/KDE/kdenetwork/kopete/libkopete/kopeteglobal.h 1035504 
  /trunk/KDE/kdenetwork/kopete/libkopete/kopeteglobal.cpp 1035504 
  /trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.h 1035504 
  /trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.cpp 1035504 
  /trunk/KDE/kdenetwork/kopete/libkopete/ui/kopetestdaction.h 1035504 
  /trunk/KDE/kdenetwork/kopete/libkopete/ui/kopetestdaction.cpp 1035504 

Diff: http://reviewboard.kde.org/r/1619/diff


Testing
-------


Screenshots
-----------


  http://reviewboard.kde.org/r/1619/s/205/


Thanks,

Bruno

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]