--===============1936917153==
Content-Type: multipart/alternative; boundary=0014851bfe883a61c704751da503

--0014851bfe883a61c704751da503
Content-Type: text/plain; charset=ISO-8859-1

Proposed patch added as an attachment to this bug report :
https://bugs.kde.org/show_bug.cgi?id=111329#c3

On Thu, Oct 1, 2009 at 11:20 AM, Romain <romainguinot@gmail.com> wrote:

> I've added a comment on this existing bug regarding jabber mood :
> https://bugs.kde.org/show_bug.cgi?id=111329#c3
> I think i see the fix as you'll see in my comment but do not have the
> possibility to test it right now, i'll probably test if for myself in the
> next few days if you haven't fixed it yet :)
>
> BTW, i'm using KDE 4.3.1 on Fedora 11.
> Best regards,
> Romain
>
>
>
>
> On Thu, Oct 1, 2009 at 4:07 AM, Matt Rogers <mattr@kde.org> wrote:
>
>> On Wednesday 30 September 2009 07:17:57 Romain wrote:
>> > Hi,
>> >
>> > I've set a mood for myself on a jabber account, but now would like to
>> >  remove it.
>> > It seems clicking "None" does not work, at least not immediately since
>> >  other colleagues still see the mood with different clients (Gajim,
>> >  Pidgin..; all linux laptops).
>> >
>> > Should the change be immediate ?
>> >
>> > I've seen in protocols/jabber/jabberaccount.cpp (1109-1122) this snippet
>> of
>> > code :
>> >
>> > void JabberAccount::slotSetMood()
>> > {
>> >     KAction *action = (KAction *)sender();
>> >     Mood::Type type = (Mood::Type)action->data().toInt();
>> >     if(type == Mood::None)
>> >     {
>> >     }
>> >     else
>> >     {
>> >         PubSubItem psi("current",
>> > Mood(type).toXml(*client()->client()->rootTask()->doc()));
>> >         JT_PubSubPublish *task = new
>> > JT_PubSubPublish(client()->client()->rootTask(), QString("
>> > http://jabber.org/protocol/mood"), psi);
>> >         task->go(true);
>> >     }
>> > }
>> >
>> >
>> > If nothing is done when Mood is None, how is one supposed to reset a
>> mood
>> > back to None once one has been chosen ?
>> >
>> > Many thanks,
>> > Romain.
>> >
>>
>> I think you've found the answer. :) Could you provide a patch to fix this,
>> or
>> at the very least file a bug (if there isn't one already?)
>> --
>> Matt
>>
>
>
>
> --
> Romain.
>



-- 
Romain.

--0014851bfe883a61c704751da503
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Proposed patch added as an attachment to this bug report : <a href=3D"https=
://bugs.kde.org/show_bug.cgi?id=3D111329#c3" target=3D"_blank">https://bugs=
.kde.org/show_bug.cgi?id=3D111329#c3</a><br><br><div class=3D"gmail_quote">=
On Thu, Oct 1, 2009 at 11:20 AM, Romain <span dir=3D"ltr">&lt;<a href=3D"ma=
ilto:romainguinot@gmail.com">romainguinot@gmail.com</a>&gt;</span> wrote:<b=
r>
<blockquote class=3D"gmail_quote" style=3D"border-left: 1px solid rgb(204, =
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">I&#39;ve added a =
comment on this existing bug regarding jabber mood : <a href=3D"https://bug=
s.kde.org/show_bug.cgi?id=3D111329#c3" target=3D"_blank">https://bugs.kde.o=
rg/show_bug.cgi?id=3D111329#c3</a><br>
I think i see the fix as you&#39;ll see in my comment but do not have the p=
ossibility to test it right now, i&#39;ll probably test if for myself in th=
e next few days if you haven&#39;t fixed it yet :)<br>
<br>BTW, i&#39;m using KDE 4.3.1 on Fedora 11. <br>Best regards, <br>Romain=
<div><div></div><div class=3D"h5"><br><br><br><br><div class=3D"gmail_quote=
">On Thu, Oct 1, 2009 at 4:07 AM, Matt Rogers <span dir=3D"ltr">&lt;<a href=
=3D"mailto:mattr@kde.org" target=3D"_blank">mattr@kde.org</a>&gt;</span> wr=
ote:<br>

<blockquote class=3D"gmail_quote" style=3D"border-left: 1px solid rgb(204, =
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><div></div><=
div>On Wednesday 30 September 2009 07:17:57 Romain wrote:<br>
&gt; Hi,<br>
&gt;<br>
&gt; I&#39;ve set a mood for myself on a jabber account, but now would like=
 to<br>
&gt; =A0remove it.<br>
&gt; It seems clicking &quot;None&quot; does not work, at least not immedia=
tely since<br>
&gt; =A0other colleagues still see the mood with different clients (Gajim,<=
br>
&gt; =A0Pidgin..; all linux laptops).<br>
&gt;<br>
&gt; Should the change be immediate ?<br>
&gt;<br>
&gt; I&#39;ve seen in protocols/jabber/jabberaccount.cpp (1109-1122) this s=
nippet of<br>
&gt; code :<br>
&gt;<br>
&gt; void JabberAccount::slotSetMood()<br>
&gt; {<br>
&gt; =A0 =A0 KAction *action =3D (KAction *)sender();<br>
&gt; =A0 =A0 Mood::Type type =3D (Mood::Type)action-&gt;data().toInt();<br>
&gt; =A0 =A0 if(type =3D=3D Mood::None)<br>
&gt; =A0 =A0 {<br>
&gt; =A0 =A0 }<br>
&gt; =A0 =A0 else<br>
&gt; =A0 =A0 {<br>
&gt; =A0 =A0 =A0 =A0 PubSubItem psi(&quot;current&quot;,<br>
&gt; Mood(type).toXml(*client()-&gt;client()-&gt;rootTask()-&gt;doc()));<br=
>
&gt; =A0 =A0 =A0 =A0 JT_PubSubPublish *task =3D new<br>
&gt; JT_PubSubPublish(client()-&gt;client()-&gt;rootTask(), QString(&quot;<=
br>
&gt; <a href=3D"http://jabber.org/protocol/mood" target=3D"_blank">http://j=
abber.org/protocol/mood</a>&quot;), psi);<br>
&gt; =A0 =A0 =A0 =A0 task-&gt;go(true);<br>
&gt; =A0 =A0 }<br>
&gt; }<br>
&gt;<br>
&gt;<br>
&gt; If nothing is done when Mood is None, how is one supposed to reset a m=
ood<br>
&gt; back to None once one has been chosen ?<br>
&gt;<br>
&gt; Many thanks,<br>
&gt; Romain.<br>
&gt;<br>
<br>
</div></div>I think you&#39;ve found the answer. :) Could you provide a pat=
ch to fix this, or<br>
at the very least file a bug (if there isn&#39;t one already?)<br>
--<br>
<font color=3D"#888888">Matt<br>
</font></blockquote></div><br><br clear=3D"all"><br></div></div>-- <br><fon=
t color=3D"#888888">Romain.<br>
</font></blockquote></div><br><br clear=3D"all"><br>-- <br>Romain.<br>

--0014851bfe883a61c704751da503--

--===============1936917153==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

--===============1936917153==--