[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Review Request: fix filetransfers in otr
From:       michael_zanetti () gmx ! net
Date:       2009-10-03 12:39:56
Message-ID: 20091003123956.2467.97199 () localhost
[Download RAW message or body]



> On 2009-09-29 09:30:54, mzanetti wrote:
> > Although file transfer (through xmpp) works here also without your patch, I think \
> > it doesn't harm. Instead it clears the situation with file transfers in the code \
> > and makes it cleaner. 
> > Ship it!
> > 
> > Thanks,
> > Michael
> 
> Florian Reinhard wrote:
> could you please commit the patch to trunk and backport to the 4.3 branch?

done... thx


- mzanetti


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1717/#review2499
-----------------------------------------------------------


On 2009-09-28 21:43:17, Florian Reinhard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1717/
> -----------------------------------------------------------
> 
> (Updated 2009-09-28 21:43:17)
> 
> 
> Review request for Kopete.
> 
> 
> Summary
> -------
> 
> When Kopete recieves a filetransfer from a chatsession that uses OTR, it tries to \
> decrypt it and fails, showing [] instead of the download buttons.  
> 
> This addresses bug 183005.
> https://bugs.kde.org/show_bug.cgi?id=183005
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdenetwork/kopete/plugins/otr/otrplugin.cpp 1028690 
> 
> Diff: http://reviewboard.kde.org/r/1717/diff
> 
> 
> Testing
> -------
> 
> icq: kopete vs miranda
> jabber: kopete vs pidgin
> 
> 
> Thanks,
> 
> Florian
> 
> 

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]