[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Re: [kopete-devel] How to unset an account mood in Kopete 0.70.90
From: Romain <romainguinot () gmail ! com>
Date: 2009-10-01 9:20:56
Message-ID: ae44b51f0910010220t49ea786di743ccff90912e53c () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
I've added a comment on this existing bug regarding jabber mood :
https://bugs.kde.org/show_bug.cgi?id=111329#c3
I think i see the fix as you'll see in my comment but do not have the
possibility to test it right now, i'll probably test if for myself in the
next few days if you haven't fixed it yet :)
BTW, i'm using KDE 4.3.1 on Fedora 11.
Best regards,
Romain
On Thu, Oct 1, 2009 at 4:07 AM, Matt Rogers <mattr@kde.org> wrote:
> On Wednesday 30 September 2009 07:17:57 Romain wrote:
> > Hi,
> >
> > I've set a mood for myself on a jabber account, but now would like to
> > remove it.
> > It seems clicking "None" does not work, at least not immediately since
> > other colleagues still see the mood with different clients (Gajim,
> > Pidgin..; all linux laptops).
> >
> > Should the change be immediate ?
> >
> > I've seen in protocols/jabber/jabberaccount.cpp (1109-1122) this snippet
> of
> > code :
> >
> > void JabberAccount::slotSetMood()
> > {
> > KAction *action = (KAction *)sender();
> > Mood::Type type = (Mood::Type)action->data().toInt();
> > if(type == Mood::None)
> > {
> > }
> > else
> > {
> > PubSubItem psi("current",
> > Mood(type).toXml(*client()->client()->rootTask()->doc()));
> > JT_PubSubPublish *task = new
> > JT_PubSubPublish(client()->client()->rootTask(), QString("
> > http://jabber.org/protocol/mood"), psi);
> > task->go(true);
> > }
> > }
> >
> >
> > If nothing is done when Mood is None, how is one supposed to reset a mood
> > back to None once one has been chosen ?
> >
> > Many thanks,
> > Romain.
> >
>
> I think you've found the answer. :) Could you provide a patch to fix this,
> or
> at the very least file a bug (if there isn't one already?)
> --
> Matt
>
--
Romain.
[Attachment #5 (text/html)]
I've added a comment on this existing bug regarding jabber mood : <a \
href="https://bugs.kde.org/show_bug.cgi?id=111329#c3">https://bugs.kde.org/show_bug.cgi?id=111329#c3</a><br>I \
think i see the fix as you'll see in my comment but do not have the possibility \
to test it right now, i'll probably test if for myself in the next few days if \
you haven't fixed it yet :)<br> <br>BTW, i'm using KDE 4.3.1 on Fedora 11. \
<br>Best regards, <br>Romain<br><br><br><br><div class="gmail_quote">On Thu, Oct 1, \
2009 at 4:07 AM, Matt Rogers <span dir="ltr"><<a \
href="mailto:mattr@kde.org">mattr@kde.org</a>></span> wrote:<br> <blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;"><div><div></div><div class="h5">On Wednesday 30 \
September 2009 07:17:57 Romain wrote:<br> > Hi,<br>
><br>
> I've set a mood for myself on a jabber account, but now would like to<br>
> remove it.<br>
> It seems clicking "None" does not work, at least not immediately \
since<br> > other colleagues still see the mood with different clients \
(Gajim,<br> > Pidgin..; all linux laptops).<br>
><br>
> Should the change be immediate ?<br>
><br>
> I've seen in protocols/jabber/jabberaccount.cpp (1109-1122) this snippet \
of<br> > code :<br>
><br>
> void JabberAccount::slotSetMood()<br>
> {<br>
> KAction *action = (KAction *)sender();<br>
> Mood::Type type = (Mood::Type)action->data().toInt();<br>
> if(type == Mood::None)<br>
> {<br>
> }<br>
> else<br>
> {<br>
> PubSubItem psi("current",<br>
> Mood(type).toXml(*client()->client()->rootTask()->doc()));<br>
> JT_PubSubPublish *task = new<br>
> JT_PubSubPublish(client()->client()->rootTask(), QString("<br>
> <a href="http://jabber.org/protocol/mood" \
target="_blank">http://jabber.org/protocol/mood</a>"), psi);<br> > \
task->go(true);<br> > }<br>
> }<br>
><br>
><br>
> If nothing is done when Mood is None, how is one supposed to reset a mood<br>
> back to None once one has been chosen ?<br>
><br>
> Many thanks,<br>
> Romain.<br>
><br>
<br>
</div></div>I think you've found the answer. :) Could you provide a patch to fix \
this, or<br> at the very least file a bug (if there isn't one already?)<br>
--<br>
<font color="#888888">Matt<br>
</font></blockquote></div><br><br clear="all"><br>-- <br>Romain.<br>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic