[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Review Request: Replaced KPassivePopup
From:       "Raphael Kubo da Costa" <kubito () gmail ! com>
Date:       2009-09-21 2:43:45
Message-ID: 20090921024345.16390.81130 () localhost
[Download RAW message or body]



> On 2009-09-21 02:24:51, Raphael Kubo da Costa wrote:
> > /trunk/KDE/kdenetwork/kopete/protocols/groupwise/gwaccount.cpp, line 586
> > <http://reviewboard.kde.org/r/1661/diff/1/?file=11705#file11705line586>
> > 
> > I've never used KNotification, so please correct me if I'm wrong.
> > 
> > Do you really need to add "Kopete: " to the title of the notification? Does it \
> > mean if you don't the user cannot know the notification was brought up by Kopete? \
> >  This applies to the other places you add "Kopete: " to the titles too.
> 
> wrote:
> yes, I think so

Then isn't it better to set the pixmap parameter to Kopete's icon instead? Requiring \
"Kopete: " in all titles may be too error-prone, and developers might forget it when \
adding new messages.

Other possibilities are creating a function that always does this, or documenting \
this need somewhere.

Anyway, it would be nice if other people commented on this as well.


- Raphael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1661/#review2408
-----------------------------------------------------------


On 2009-09-20 13:53:02, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1661/
> -----------------------------------------------------------
> 
> (Updated 2009-09-20 13:53:02)
> 
> 
> Review request for Kopete.
> 
> 
> Summary
> -------
> 
> I've replaced all the KPassivePopup with KNotifications.
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdenetwork/kopete/protocols/groupwise/gwaccount.cpp 1025366 
> /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 1025366 
> /trunk/KDE/kdenetwork/kopete/protocols/oscar/oscaraccount.cpp 1025366 
> 
> Diff: http://reviewboard.kde.org/r/1661/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Davide
> 
> 

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]