[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Re: [kopete-devel] Review Request: add "/url" ability to kopete
From: "Antonio Gattoo" <kdejkffdwitnas () mail ! ru>
Date: 2009-09-13 17:27:39
Message-ID: 20090913172739.17068.77368 () localhost
[Download RAW message or body]
> On 2009-09-11 18:06:17, Matt Rogers wrote:
> > Looks fine now! Do you have an svn account already or should I commit this?
I dont have an svn acc, so would you please commit this. Thanks in advance
- Antonio
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1213/#review2293
-----------------------------------------------------------
On 2009-08-27 20:06:28, Antonio Gattoo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1213/
> -----------------------------------------------------------
>
> (Updated 2009-08-27 20:06:28)
>
>
> Review request for Kopete.
>
>
> Summary
> -------
>
> This all is about http://bugs.kde.org/show_bug.cgi?id=84080
>
> What i did:
>
> - when a new Chat is opened, and a new ChatSession is created, i check for a \
> appropriate file with lasturls for first chatmember, and try to initialize \
> ChatSession's variable veryLastUrl;
> - when sending/receiving messages, i check if there is an url(s) in a message. if \
> any: i set a veryLastUrl variable for current ChatSession and save it in proper \
> file;
> - i can type "/url" in chat window and a veryLastUrl will be opened in default \
> browser;
>
> What i didn't managed to do:
>
> - i didn't managed to set a configurable hotkey for calling lasturl (like "/url \
> does"). i tried to solve it like this \
> http://forum.kde.org/viewtopic.php?f=64&t=62455;
> - i didn't managed to put all my code to /history .cpp files (don't know why, it \
> just refused to work there). i think this part about initializing and prosessing \
> urls in messages should be inside history plugin.
> - using this patch one will not be able to look through the history for urls, it \
> will work only for further using;
>
> My suggestions:
>
> - urls should be saved in proper .xml format (.txt now). So we could think about an \
> urls history.
> - configurable hotkey is needed (waiting for your help)
> - "/url" command can be broaden to smth like "/url history_check" to look through \
> the history and make a proper .xml file for history_urls dialog (or it can be \
> included in usual history dialog). or it can just find first url in history \
> (antichronological way), initialize veryLastUrl for current ChatSession and create \
> a appropriate file.
>
> I installed Kubuntu and passed through techbase guide only a month ago, so i'm new \
> to Linux, KDE and Qt at all. I'm going to become a good KDE programmer, but i'm not \
> yet, so please don't be cruel with my patch and my knowledges i'd appreciate any \
> advice.
>
> This addresses bug 84080.
> https://bugs.kde.org/show_bug.cgi?id=84080
>
>
> Diffs
> -----
>
> /trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.h 1006039
> /trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.cpp 1006039
> /trunk/KDE/kdenetwork/kopete/libkopete/kopetecommandhandler.h 1006039
> /trunk/KDE/kdenetwork/kopete/libkopete/kopetecommandhandler.cpp 1006039
> /trunk/KDE/kdenetwork/kopete/libkopete/kopetemessage.h 1006039
> /trunk/KDE/kdenetwork/kopete/libkopete/kopetemessage.cpp 1006039
>
> Diff: http://reviewboard.kde.org/r/1213/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Antonio
>
>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic