[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Review Request: GaduGadu import/export contacts
From:       "Matt Rogers" <mattr () kde ! org>
Date:       2009-09-14 17:22:43
Message-ID: 20090914172243.19848.65658 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1604/#review2359
-----------------------------------------------------------


Do we need the menu options to explicitly export and import contacts from the server? \
Almost all of the other protocols just do this by default already. What keeps Gadu \
from doing the same thing here?


/trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.cpp
<http://reviewboard.kde.org/r/1604/#comment1646>

    the red indicator here means there's extra whitespace. please remove it.



/trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.cpp
<http://reviewboard.kde.org/r/1604/#comment1647>

    fix whitespace here too.



/trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.cpp
<http://reviewboard.kde.org/r/1604/#comment1648>

    whitespace



/trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.cpp
<http://reviewboard.kde.org/r/1604/#comment1649>

    whitespace



/trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.cpp
<http://reviewboard.kde.org/r/1604/#comment1650>

    whitespace



/trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.cpp
<http://reviewboard.kde.org/r/1604/#comment1651>

    whitespace



/trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.cpp
<http://reviewboard.kde.org/r/1604/#comment1652>

    whitespace



/trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.cpp
<http://reviewboard.kde.org/r/1604/#comment1653>

    whitespace



/trunk/KDE/kdenetwork/kopete/protocols/gadu/gadueditaccount.cpp
<http://reviewboard.kde.org/r/1604/#comment1654>

    whitespace


- Matt


On 2009-09-14 12:53:19, Jakub Grandys wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1604/
> -----------------------------------------------------------
> 
> (Updated 2009-09-14 12:53:19)
> 
> 
> Review request for Kopete.
> 
> 
> Summary
> -------
> 
> Complete fix for importing and exporting contacts list. All known to me related \
>                 bugs are fixed:
> - improper generation of exported list
> - bad handling of messed up lists
> - ability to add contact with empty, nonnumerical or UID=0
> - with empty contacts list you wouldn't receive ANY message or contacts list from \
> server 
> New features:
> - delete contacts list
> - manual import from account's action menu
> - config options for both import on login in and export contacts on any change to \
>                 contacts list to server (currently not configurable, default is \
>                 same as now)
> - revoked action menu (see screenshots)
> 
> 
> This addresses bugs 184696, 204282 and 204285.
> https://bugs.kde.org/show_bug.cgi?id=184696
> https://bugs.kde.org/show_bug.cgi?id=204282
> https://bugs.kde.org/show_bug.cgi?id=204285
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdenetwork/kopete/kopete/kopete.notifyrc 1023241 
> /trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.h 1023241 
> /trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.cpp 1023241 
> /trunk/KDE/kdenetwork/kopete/protocols/gadu/gaducontactlist.cpp 1023241 
> /trunk/KDE/kdenetwork/kopete/protocols/gadu/gadueditaccount.cpp 1023241 
> /trunk/KDE/kdenetwork/kopete/protocols/gadu/gadusession.h 1023241 
> /trunk/KDE/kdenetwork/kopete/protocols/gadu/gadusession.cpp 1023241 
> /trunk/KDE/kdenetwork/kopete/protocols/gadu/ui/gadueditaccountui.ui 1023241 
> 
> Diff: http://reviewboard.kde.org/r/1604/diff
> 
> 
> Testing
> -------
> 
> Works for me ;)
> 
> 
> Screenshots
> -----------
> 
> New ActionMenu
> http://reviewboard.kde.org/r/1604/s/202/
> Old ActionMenu
> http://reviewboard.kde.org/r/1604/s/204/
> 
> 
> Thanks,
> 
> Jakub
> 
> 

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]