[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Review Request: Show the contact picture if
From:       "Aleix Pol" <aleixpol () kde ! org>
Date:       2009-09-12 14:34:28
Message-ID: 20090912143428.10358.62010 () localhost
[Download RAW message or body]



> On 2009-08-26 16:20:54, Gustavo Boiko wrote:
> > I haven't seen the code yet, but here are some thoughts.
> > Looking at the screenshot, it seems to me that the image is kinda lost in the \
> > contest. Instead of that, it would probably be a better idea (if seeing the big \
> > picture is really desired) to arrange items in icon mode instead of item mode, \
> > and then set a bigger icon size to them. 
> > Wouldn't it be enough if we just had a tooltip showing all the info including the \
> > contact icon?
> 
> Aleix Pol wrote:
> I don't want tooltips. People wants to be able to see the chatee at anytime. Plus \
> all other clients do that and we have a lot of wasted space there :/. 
> Here we have 2 icons: the state and the picture. Moving to icon would provide a \
> very big status notification. 
> Matt Rogers wrote:
> I like the idea of adding the picture to the participants list. Regarding the \
> layout, what if we provided a larger picture in the participants list next to each \
> participant? I'm thinking 128x128 at least.

The size depends on what we get. the metaContact's picture is usually 96x96 in this \
case. I don't know if we're scaling them ourselves or it's the protocols that don't \
give us more.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1394/#review2153
-----------------------------------------------------------


On 2009-09-12 14:33:25, Aleix Pol wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1394/
> -----------------------------------------------------------
> 
> (Updated 2009-09-12 14:33:25)
> 
> 
> Review request for Kopete.
> 
> 
> Summary
> -------
> 
> I was browsing through the code thinking of some way to improve the chat window.
> 
> I had 2 problems. I wanted to see the contact's picture in a reasonable format \
> (bigger than in the chat view) and the participants list view looked kind of \
> boring/empty most of the time, so I came up with this patch that adds a delegate \
> that can do that. 
> It could be improved a little bit but here you can see (mostly in the screenshot) \
> what the patch does and does not. 
> Hope you find it useful.
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdenetwork/kopete/libkopete/chatsessionmemberslistmodel.h 1022530 
> trunk/KDE/kdenetwork/kopete/libkopete/chatsessionmemberslistmodel.cpp 1022530 
> trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmemberslistview.cpp 1022530 
> trunk/KDE/kdenetwork/kopete/kopete/chatwindow/CMakeLists.txt 1022530 
> trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmembersdelegate.h PRE-CREATION 
> trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmembersdelegate.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1394/diff
> 
> 
> Testing
> -------
> 
> Umm... use it...
> 
> 
> Screenshots
> -----------
> 
> 
> http://reviewboard.kde.org/r/1394/s/190/
> 
> 
> Thanks,
> 
> Aleix
> 
> 

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]