[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Review Request: add a new message action in
From:       Tiago Salem Herrmann <salem () mandriva ! com>
Date:       2009-06-25 17:07:47
Message-ID: 4A43AEE3.90409 () mandriva ! com
[Download RAW message or body]

Tiago Salem Herrmann wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/878/
> -----------------------------------------------------------
> 
> (Updated 2009-06-24 18:00:51.762080)
> 
> 
> Review request for Kopete.
> 
> 
> Changes
> -------
> 
> argh, the patch was broken.
> 
> 
> Summary
> -------
> 
> In order to have a good usability when receiving voice clips from msn, a new \
> message action is required. For this patch I used the file transfer type schema as \
> base to the voice clip message type. I know that including phonon code to the chat \
> window part isn't the best approach, but for the moment I can't  figure out a \
> better way to do this. Any ideas on how to solve this situation? 
> 
> Diffs (updated)
> -----
> 
> /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/CMakeLists.txt 982423 
> /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmessagepart.h 982423 
> /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmessagepart.cpp 982423 
> /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopetechatwindowstyle.h 982423 
> /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/kopetechatwindowstyle.cpp 982423 
> /trunk/KDE/kdenetwork/kopete/libkopete/kopetemessage.h 982423 
> /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmchatmanager.cpp 982423 
> 
> Diff: http://reviewboard.kde.org/r/878/diff
> 
> 
> Testing
> -------
> 
> I have tested this patch with the latest libmsn (from svn), and I am able to play \
> and save voice clips directly from the chat window. 
> 
> Thanks,
> 
> Tiago
> 
> _______________________________________________
> kopete-devel mailing list
> kopete-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kopete-devel
> 

Hi,

would it be possible for someone to review this patch. I know it can't 
be applied right now to trunk, but to keep working on my GSoC proposal I 
need to know if we can keep the patch as is, or if we need to change its 
layout.

Thank you.
Tiago Salem Herrmann
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]