'Re: [kopete-devel] Historyimport Bugfix'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Historyimport Bugfix
From:       Timo Schlüßler <timo () schluessler ! org>
Date:       2009-06-23 10:22:08
Message-ID: 4A40ACD0.3010500 () schluessler ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

Maddev from launchpad suggested to use QRegExp because the resulting 
code is much cleaner and easier to understand. Also there were problems 
(they weren't able to import anything) for some users when they tried to 
import their pidgin logs, because pidgin changed its log format at least 
once. This new QRegExp mechanism is much more resistant against these 
changes and also against broken pidgin xml-files (e.g. missing close-tags).

What do you think?

Timo

Olivier Goffart wrote:
> Le Saturday 20 June 2009, Timo Schlüßler a écrit :
>   
>> Hi,
>>
>> as reported on https://bugs.launchpad.net/bugs/378428 there were
>> problems when importing history logs from pidgin, because of a slightly
>> different format used by different pidgin versions.
>>
>> The latest patch posted there (which is also attached to this email)
>> solves the mentioned problems and should be applied to the kopete source.
>> Could someone (maybe Olivier Goffart?) of you do this? It would be very
>> nice if this patch will made it into the first release of KDE 4.3.
>>     
>
> Using QTextStream is a good thing.
> Byt why can't you use QXmlStreamReader anymore?
> You can use QXmlStreamReader::addData to add the decoded data.
>
> _______________________________________________
> kopete-devel mailing list
> kopete-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kopete-devel
>   

[Attachment #5 (text/html)]

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=UTF-8" http-equiv="Content-Type">
  <title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Maddev from launchpad suggested to use QRegExp because the resulting
code is much cleaner and easier to understand. Also there were problems
(they weren't able to import anything) for some users when they tried
to import their pidgin logs, because pidgin changed its log format at
least once. This new QRegExp mechanism is much more resistant against
these changes and also against broken pidgin xml-files (e.g. missing
close-tags).<br>
<br>
What do you think?<br>
<br>
Timo<br>
<br>
Olivier Goffart wrote:
<blockquote cite="mid:200906230254.15949.ogoffart@kde.org" type="cite">
  <pre wrap="">Le Saturday 20 June 2009, Timo Schlüßler a écrit :
  </pre>
  <blockquote type="cite">
    <pre wrap="">Hi,

as reported on <a class="moz-txt-link-freetext" \
href="https://bugs.launchpad.net/bugs/378428">https://bugs.launchpad.net/bugs/378428</a> \
there were problems when importing history logs from pidgin, because of a slightly
different format used by different pidgin versions.

The latest patch posted there (which is also attached to this email)
solves the mentioned problems and should be applied to the kopete source.
Could someone (maybe Olivier Goffart?) of you do this? It would be very
nice if this patch will made it into the first release of KDE 4.3.
    </pre>
  </blockquote>
  <pre wrap=""><!---->
Using QTextStream is a good thing.
Byt why can't you use QXmlStreamReader anymore?
You can use QXmlStreamReader::addData to add the decoded data.

_______________________________________________
kopete-devel mailing list
<a class="moz-txt-link-abbreviated" \
href="mailto:kopete-devel@kde.org">kopete-devel@kde.org</a> <a \
class="moz-txt-link-freetext" \
href="https://mail.kde.org/mailman/listinfo/kopete-devel">https://mail.kde.org/mailman/listinfo/kopete-devel</a>
  </pre>
</blockquote>
</body>
</html>

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

[prev in list] [next in list] [prev in thread] [next in thread] 