[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Jabber resources
From:       Matt Rogers <mattr () kde ! org>
Date:       2009-06-22 16:01:38
Message-ID: 200906221101.38686.mattr () kde ! org
[Download RAW message or body]

On Monday 22 June 2009 08:29:20 am Pali Rohár wrote:
> I create patch, which add option to jabber account for merging all
> messages from all contact's resources to one window/tab.
>
> > On Saturday 20 June 2009 21:37:32 Jan Ritzerfeld wrote:
> >> Am Samstag, 20. Juni 2009 schrieb Pali Rohár:
> >>> Hello,
> >>> if I chating with somebody throw jabber protocol and he change
> >>> resource, all new messages from him are shown in new tab (or window).
> >>
> >> https://bugs.kde.org/show_bug.cgi?id=111537
> >> https://bugs.kde.org/show_bug.cgi?id=142650
> >> https://bugs.kde.org/show_bug.cgi?id=175078
> >> https://bugs.kde.org/show_bug.cgi?id=194808
> >>
> >>> It is possible set up kopete to show all incomming messages from all
> >>> jabber contacts resources to one tab?
> >>
> >> And to which address the outgoing messages should be sent?
> >
> > There is also the fact that some people want different chat windows for
> > different resources.
> >
> > Maybe add an option to redirect messages from all contact's resources to
> > the same chat window.
> >
> > Detlev.
> >
> >
> >

Comments on the patch:

Don't use QString::null, use QString() instead for empty QStrings.

merging messages should default to true, IMHO.

Otherwise, looks ok. 
-- 
Matt
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

[prev in list] [next in list] [prev in thread] [next in thread]