[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Review Request: D-Bus Interface: Adds the
From:       "Roman Jarosz" <kedgedev () gmail ! com>
Date:       2009-05-05 15:55:22
Message-ID: 20090505155522.4710.22602 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/670/#review1057
-----------------------------------------------------------

Ship it!


Looks good

- Roman


On 2009-05-05 08:34:25, Ivan Cukic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/670/
> -----------------------------------------------------------
> 
> (Updated 2009-05-05 08:34:25)
> 
> 
> Review request for Kopete.
> 
> 
> Summary
> -------
> 
> In the documentation, it is stated that openChat and contactProperties can accept \
> MetaContact IDs. This patch would make that statement true. 
> DBus interface now returns MetaContact IDs instead of the old contactIDs so \
> supporting them in the above mentioned functions is (IMO) a must. 
> By applying this patch, no functionality is lost so the contacts can still be \
> managed through old contactIDs and display names. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdenetwork/kopete/kopete/kopetedbusinterface_p.cpp 963671 
> 
> Diff: http://reviewboard.kde.org/r/670/diff
> 
> 
> Testing
> -------
> 
> Testing done with a couple of contacts, both kabc-synced and not.
> 
> 
> Thanks,
> 
> Ivan
> 
> 

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]