[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Review Request: make offline contacts hidden on
From:       "Roman Jarosz" <kedgedev () gmail ! com>
Date:       2009-03-31 16:26:57
Message-ID: 20090331162657.26319.17656 () localhost
[Download RAW message or body]



> On 2009-03-31 09:07:55, Matt Rogers wrote:
> > This is not ready to commit. You're not checking the values from your \
> > qobject_casts (which can return 0) which could lead to crashes. It's not \
> > particularly clear to me from reading the surrounding code that we're actually in \
> > a code path that applies to metacontacts only. 
> > Also, if you're hiding the offline portion of the metacontact, how does the user \
> > know that kopete didn't just delete that contact in the metacontact on its own? \
> > (i.e. how you do make sure that it doesn't look like a bug). Do we have a way of \
> > showing them that Kopete didn't just lose/delete their contact from the contact \
> > list? 

The code applies only to metaContacts so the check isn't necessary, maybe it would be \
better if we change the name of function from paintItem to paintMetaContactItem.

About the second part, IIRC we hide the offline icons in previous Kopete versions too \
so this isn't now feature.


- Roman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/486/#review758
-----------------------------------------------------------


On 2009-03-31 07:00:44, Benson Tsai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/486/
> -----------------------------------------------------------
> 
> (Updated 2009-03-31 07:00:44)
> 
> 
> Review request for Kopete.
> 
> 
> Summary
> -------
> 
> When hide offline contacts is in effect, offline contacts should be hidden even if \
> the metacontact is online. So only the online contacts (of the metacontact) should \
> be shown. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitemdelegate.h 947102 
> /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitemdelegate.cpp 947102 
> 
> Diff: http://reviewboard.kde.org/r/486/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benson
> 
> 

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]