[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Review Request: Option to dont show warning
From:       "Matt Rogers" <mattr () kde ! org>
Date:       2009-03-25 20:48:56
Message-ID: 20090325204856.10206.71080 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/371/#review624
-----------------------------------------------------------

Ship it!


looks fine. please commit.

- Matt


On 2009-03-24 23:39:33, Pali Rohár wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/371/
> -----------------------------------------------------------
> 
> (Updated 2009-03-24 23:39:33)
> 
> 
> Review request for Kopete.
> 
> 
> Summary
> -------
> 
> This patch add option to dont show warning message before leaving (or closing \
> window) group chat (Skype doesnt leave group chat when user close chat window or \
> quit skype, so dont warn user about this). It add method setWarnGroupChat(bool) in \
> Kopete::ChatSession. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatview.cpp 941902 
> trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.h 941902 
> trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.cpp 941902 
> 
> Diff: http://reviewboard.kde.org/r/371/diff
> 
> 
> Testing
> -------
> 
> It works for me.
> 
> 
> Screenshots
> -----------
> 
> This patch add method setWarnGroupChat(bool) in Kopete::ChatSession to \
> enable/dissable showing this message http://reviewboard.kde.org/r/371/s/71/
> 
> 
> Thanks,
> 
> Pali
> 
> 

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]