[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Review Request: aim chatroom join fix and
From:       "Matt Rogers" <mattr () kde ! org>
Date:       2009-03-25 3:27:48
Message-ID: 20090325032748.28740.87977 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/390/#review605
-----------------------------------------------------------

Ship it!


nice work. fix the small style nitpick if you want to, and then please commit and mark as submitted.


/trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/chatroomhandler.h
<http://reviewboard.kde.org/r/390/#comment392>

    style. :) 
    
    I prefer "m_" prefix for members rather than just "m". yes, this is nitpicking. :)


- Matt


On 2009-03-22 20:07:37, Benson Tsai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/390/
> -----------------------------------------------------------
> 
> (Updated 2009-03-22 20:07:37)
> 
> 
> Review request for Kopete.
> 
> 
> Summary
> -------
> 
> Fix aim chatroom join support.
> 
> Add support for chatroom invitations (just receiving).
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdenetwork/kopete/protocols/oscar/aim/aimaccount.cpp 942763 
>   /trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/CMakeLists.txt 942763 
>   /trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/chatroomhandler.h PRE-CREATION 
>   /trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/chatroomhandler.cpp PRE-CREATION 
>   /trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/client.h 942763 
>   /trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/client.cpp 942763 
>   /trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/tasks/chatroomtask.h PRE-CREATION 
>   /trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/tasks/chatroomtask.cpp PRE-CREATION 
>   /trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/tasks/chatservicetask.cpp 942763 
>   /trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/tasks/messagereceivertask.h 942763 
>   /trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/tasks/messagereceivertask.cpp 942763 
>   /trunk/KDE/kdenetwork/kopete/protocols/oscar/liboscar/tasks/profiletask.cpp 942763 
>   /trunk/KDE/kdenetwork/kopete/protocols/oscar/oscaraccount.h 942763 
>   /trunk/KDE/kdenetwork/kopete/protocols/oscar/oscaraccount.cpp 942763 
> 
> Diff: http://reviewboard.kde.org/r/390/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benson
> 
>

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]