[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Review Request: PGP encrypted messages are not
From:       "Matt Rogers" <mattr () kde ! org>
Date:       2009-03-25 3:20:29
Message-ID: 20090325032029.28605.92375 () localhost
[Download RAW message or body]



> On 2009-03-20 09:04:12, Matt Rogers wrote:
> > Looks like the right way to me. Do I need to commit this?
> 
> Jaroslav Reznik wrote:
> I'll commit it, thanks.

Be sure to mark the review as submitted when you've committed the fixes.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/367/#review535
-----------------------------------------------------------


On 2009-03-20 06:35:22, Jaroslav Reznik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/367/
> -----------------------------------------------------------
> 
> (Updated 2009-03-20 06:35:22)
> 
> 
> Review request for Kopete.
> 
> 
> Summary
> -------
> 
> PGP encrypted messages are not handled correctly (from SVN revision 568270).
> 
> This patch is checking if kopete-cryptography plugin is available, if not, original \
> message ("This message is encrypted") is kept. I'm not sure if it is allowed (or if \
> it is best way to do it) to check external plugin. 
> This patch should be bundled with fix for kopete-cryptography bug #177302.
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp 941694 
> trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbergroupcontact.cpp 941694 
> 
> Diff: http://reviewboard.kde.org/r/367/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaroslav
> 
> 

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]