[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Review Request: Yahoo File Transfers
From:       "Matt Rogers" <mattr () kde ! org>
Date:       2009-03-16 21:35:11
Message-ID: 20090316213511.20176.35310 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/263/#review503
-----------------------------------------------------------

Ship it!


Looks fine. Even though it's not perfect, I still think it should be committed.

- Matt


On 2009-03-16 14:01:35, jgroszko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/263/
> -----------------------------------------------------------
> 
> (Updated 2009-03-16 14:01:35)
> 
> 
> Review request for Kopete.
> 
> 
> Summary
> -------
> 
> I'm trying to get Yahoo File Transfers working again, but I've gotten to a point \
> where I need input from someone with a fresh set of eyes or more brains than me. 
> Receiving files works, but sending files does not. About 10k into the transfer I \
> see an unknown error code 16, and wireshark shows a bunch of TCP Duplicate ACKs. \
> The error looks like this in the debug log: 
> kopete(6494)/kopete (yahoo - raw protocol) SendFileTask::transmitData: read: 1024  \
> written:  1024                  kopete(6494)/kopete (yahoo) \
> YahooAccount::slotFileTransferBytesProcessed: Transfer:  2  Bytes: 10240            \
>  kopete(6494)/kopete (yahoo - raw protocol) SendFileTask::transmitData:             \
>  kopete(6494)/kopete (yahoo - raw protocol) SendFileTask::connectFailed: 16 :  "an \
> unknown/unexpected error has happened"  
> Some input/insight would be awesome, since I'd like to get this working again...
> 
> 
> This addresses bug 159584.
> https://bugs.kde.org/show_bug.cgi?id=159584
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/filetransfernotifiertask.cpp \
> 937605  trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/logintask.cpp 937605 
> trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/sendfiletask.h 937605 
> trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/sendfiletask.cpp 937605 
> trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/yahootypes.h 937605 
> trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/ymsgprotocol.cpp 937605 
> 
> Diff: http://reviewboard.kde.org/r/263/diff
> 
> 
> Testing
> -------
> 
> Received files sent from a Windows Yahoo client, unable to send files to a Windows \
> Yahoo Client 
> 
> Thanks,
> 
> jgroszko
> 
> 

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]