[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Review Request: Fix Kopete bug 182366: Display
From:       Tiago Salem Herrmann <salem () mandriva ! com>
Date:       2009-02-16 13:46:22
Message-ID: 49996E2E.5030106 () mandriva ! com
[Download RAW message or body]

Michaël Larouche wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/71/
> -----------------------------------------------------------
> 
> Review request for Kopete.
> 
> 
> Summary
> -------
> 
> This patch fix bug 182366 that affected WLM display name when not using global \
> nickname 
> 
> Diffs
> -----
> 
> /branches/KDE/4.2/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp 925696 
> 
> Diff: http://reviewboard.kde.org/r/71/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michaël
> 
> _______________________________________________
> kopete-devel mailing list
> kopete-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kopete-devel
> 
It is better to avoid accessing NotificationServerConnection members 
directly.

Is it possible to change "m_server->mainConnection->myDisplayName.c_str()"
by "myself()->property( \
Kopete::Global::Properties::self()->nickName()).value().toString().toAscii().data()" \
? If gotDisplayName() is being triggered properly by libmsn, the nickName property \
should be set already at that time.

Thanks.
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]