[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Patch for
From:       David Faure <faure () kde ! org>
Date:       2008-12-22 12:55:48
Message-ID: 200812221355.49279.faure () kde ! org
[Download RAW message or body]

On Sunday 21 December 2008, Roman Jarosz wrote:
> On Sun, 21 Dec 2008 13:53:24 +0100, Andrea Cimino <andreacimino@gmail.com> wrote:
> 
> > I tried to make a patch for this:
> >
> > http://techbase.kde.org/Projects/Kopete/JuniorJobs#Page_Up_.22Just_Works.22
> >
> > I like the patched behvaour: if you didn't entered some text in the
> > KRichTextEdit, you scroll the chat history,
> > otherwise you get the same behaviour as before.
> 
> Looks good, just one thought maybe it would be better to use toPlainText().isEmpty()
> because IMHO you can be atBlockStart even if you have entered some text.

toPlainText().isEmpty() is slooooow though.

Why not just document()->isEmpty on the QTextEdit, if there is indeed a QTextEdit involved?

-- 
David Faure, faure@kde.org, sponsored by Qt Software @ Nokia to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]