[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    [kopete-devel] Kopete statistics plugin fix
From:       "Lior Mualem" <lior.com () gmail ! com>
Date:       2008-11-04 23:44:01
Message-ID: 1c4f34e40811041544i47d91564u337aa5d5e8f4d255 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi,
I've fixed the statistics plugin in kopete, I've attached a patch.

I seems to be related to these two bugs (one is a duplicate of the other):
https://bugs.kde.org/show_bug.cgi?id=172940
https://bugs.kde.org/show_bug.cgi?id=174123


Lior

[Attachment #5 (text/html)]

<div dir="ltr">Hi, <br>I&#39;ve fixed the statistics plugin in kopete, I&#39;ve \
attached a patch.<br><br>I seems to be related to these two bugs (one is a duplicate \
of the other):<br><a \
href="https://bugs.kde.org/show_bug.cgi?id=172940">https://bugs.kde.org/show_bug.cgi?id=172940</a><br>
 <a href="https://bugs.kde.org/show_bug.cgi?id=174123">https://bugs.kde.org/show_bug.cgi?id=174123</a><br><br><br>Lior<br><br></div>



["kopete_statistics_fix.patch" (text/x-diff)]

Index: statisticsdb.cpp
===================================================================
--- statisticsdb.cpp	(revision 879170)
+++ statisticsdb.cpp	(working copy)
@@ -104,14 +104,14 @@
 	QSqlQuery query ( m_db );
 
 	// prepare query
-	if ( query.prepare ( statement ) )
+	if ( !query.prepare ( statement ) )
 	{
 		kError ( 14315 ) << "error" << query.lastError().text() << "on query:" << statement;
 		return QStringList();
 	}
 
 	// do query
-	if ( query.exec() )
+	if ( !query.exec() )
 	{
 		kError ( 14315 ) << "error" << query.lastError().text() << "on query:" << statement;
 		return QStringList();


_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]