[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] [PATCH] Suppress Sending Notification
From:       "Roman Jarosz" <roman.jarosz () gmail ! com>
Date:       2008-10-27 19:17:10
Message-ID: op.ujo6iwfyrj95b0 () localhost
[Download RAW message or body]

On Mon, 27 Oct 2008 13:51:30 +0100, Matt Rogers <mattr@kde.org> wrote:

> On Monday 27 October 2008 03:08:16 Roman Jarosz wrote:
>> On Mon, 27 Oct 2008 05:00:41 +0100, Matt Rogers <mattr@kde.org> wrote:
>> > On Sunday 26 October 2008 16:54:00 Roman Jarosz wrote:
>> >> Hi,
>> >>
>> >> some jabber (gtalk) clients don't send delivery message back so
>> >> the sending notification is turning forever in chat window (bug  
>> 173599).
>> >>
>> >> I've created patch which allows to suppress the sending notification.
>> >>
>> >> Is it ok to commit? I'm asking because I've added code into
>> >> Kopete::Contact
>> >> so other protocols can use it too in future.
>> >>
>> >> Regards,
>> >> Roman
>> >
>> > There isn't a diff attached. It looks like the output of svn st
>> > instead...
>>
>> Oh right :), here is the diff.
>
> Hmm. I don't like this (The concept that is; the code looks fine, of  
> course)
>
>  XMPP (through an XEP, the number of which I can't remember right now)  
> allows
> a client to define whether or not they support the various different
> notifications (typing, etc.) and we should be using that instead of  
> adding
> something in libkopete to work around an issue with one protocol.

I agree if we can detect this we should use it.
Anybody know were I can find it in jabber? Gof?

Roman

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]