[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] [PATCH] history plugin (kopete 4.1.1): do not
From:       Olivier Goffart <ogoffart () kde ! org>
Date:       2008-10-02 16:40:23
Message-ID: 200810021840.27051.ogoffart () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Le dimanche 28 septembre 2008, Matěj Laitl a écrit  :
> Hi kopete devs,
> I've got problems with history plugin - when history is shown, messages get
> reordered based on their arrival time. However, at least some protocols
> (ICQ) use remote user's clock for recording arrival time, which results in
> messed up history when your buddy's clock is skewed.
>
> This small patch just removes the reordering mechanism, as messages are
> already in correct order in history files (e.g. semantically chronological,
> even when recorded arrival times are messed up)
>
> The patch is based on kopete 4.1.1, should apply to trunk too.
>
> 	Matěj Laitl


Well, the patch seems wrong if you have several subcontact in your metacontact 
and you are merging.



And it seems that code has changed in trunk to use quicksort, which is way 
faster, but not as fast as a correctly done merging as it is done in the 
later readMessages function  (but it's more complex)


Thanks for your patch 

-- 
Gof

["signature.asc" (application/pgp-signature)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]